355599 – www-plugins/adobe-flash: memcpy-to-memmove.sh fails with non-bash shells

Bug 355599 - www-plugins/adobe-flash: memcpy-to-memmove.sh fails with non-bash shells

Summary: www-plugins/adobe-flash: memcpy-to-memmove.sh fails with non-bash shells

Status:	RESOLVED DUPLICATE of bug 354073

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Jim Ramsay (lack) (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-19 17:46 UTC by Michał Górny
Modified:	2011-02-22 13:34 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2011-02-19 17:46:18 UTC

The included script carries /bin/sh shebang, though it doesn't work with dash. This is due to:

	trap "rm -f $TEMP_OUTPUT" ERR

Where ERR is a ksh-specific extension. I'd suggest using EXIT instead.

'echo -n' & 'echo -ne' need to be replaced with printf too.

Comment 1 Dror Levin (RETIRED) gentoo-dev

2011-02-20 20:28:01 UTC

Also, the script is run as

  sh "${FILESDIR}/memcpy-to-memmove.sh" libflashplayer.so

So simply changing the shebang doesn't help, this line (130 in the ebuild) must be fixed to run bash instead of sh.

Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev

2011-02-22 13:34:23 UTC


*** This bug has been marked as a duplicate of bug 354073 ***