334631 – sys-block/disktype does not respect LDFLAGS

Bug 334631 - sys-block/disktype does not respect LDFLAGS

Summary: sys-block/disktype does not respect LDFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Forensics Herd [disbanded]

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ldflags
	Show dependency tree

Reported:	2010-08-26 14:52 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2011-09-28 00:53 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (disktype-9:20100826-002909.log,3.35 KB, text/plain) 2010-08-26 14:52 UTC, Diego Elio Pettenò (RETIRED)	Details
Patch to disktype-9.ebuild to use emake and to respect LDFLAGS (disktype-9.ebuild.patch,361 bytes, patch) 2010-08-26 21:02 UTC, Kevin Pyle	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:52:11 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-26 14:52:22 UTC

Created attachment 244733 [details]
Build log

Comment 2 Kevin Pyle 2010-08-26 21:02:45 UTC

Created attachment 244787 [details, diff]
Patch to disktype-9.ebuild to use emake and to respect LDFLAGS

The upstream Makefile explicitly sets LDFLAGS to nothing and CFLAGS to a fixed value.  Since the Gentoo ebuild already sets CC= and CFLAGS= on the make command line, this patch follows the same approach by also setting LDFLAGS via the make command line.  This patch also switches to emake, since the upstream build system seems to be parallel safe.  I built with MAKEOPTS=-j on a 4-core machine with no problem and the Makefile looks correct.

Comment 3 Tim Harder gentoo-dev

2011-09-28 00:53:28 UTC

Fixed in CVS.