Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 331859 - app-misc/mouseremote does not respect LDFLAGS
Summary: app-misc/mouseremote does not respect LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
: 331861 (view as bug list)
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2010-08-09 16:40 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-08-13 15:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (mouseremote-0.90:20100808-220009.log,4.87 KB, text/plain)
2010-08-09 16:40 UTC, Diego Elio Pettenò (RETIRED)
Details
Diff from mouseremote-0.90 (mouseremote-0.90.ebuild,2.02 KB, text/plain)
2010-08-13 04:18 UTC, Dane Smith (RETIRED)
Details
The *real* diff from mouseremote-0.90.ebuild (mouseremote.diff,1.77 KB, text/plain)
2010-08-13 04:19 UTC, Dane Smith (RETIRED)
Details
Diff from mouseremote-gentoo.patch (mouseremote-gentoo.patch.diff,854 bytes, text/plain)
2010-08-13 04:21 UTC, Dane Smith (RETIRED)
Details
New mouseremote-gentoo.patch (mouseremote-gentoo.diff,1.10 KB, text/plain)
2010-08-13 04:21 UTC, Dane Smith (RETIRED)
Details
mouseremote-0.90-makefile.diff (mouseremote-0.90-makefile.patch,511 bytes, text/plain)
2010-08-13 04:22 UTC, Dane Smith (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-09 16:40:38 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-09 16:40:53 UTC
Created attachment 242069 [details]
Build log
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-11 01:03:59 UTC
*** Bug 331861 has been marked as a duplicate of this bug. ***
Comment 3 Dane Smith (RETIRED) gentoo-dev 2010-08-13 04:18:37 UTC
Created attachment 242701 [details]
Diff from mouseremote-0.90

I made a good number of changes, and as this is a stable package on x86, this should probably be revbumped.

Changelist:
Resolved the LDFLAGS issue. That is taken care of in one of the following patches. To do this in a readable manner, I removed the changes to the Makefile from the rather large mouseremote-gentoo.patch file and created a .diff for just Makefile changes.

I also made a number of cosmetic changes. Moved epatch to src_unpack. Added a ton of || die statements in src_install. Modified emake in src_compile to respect the toolchain instead of blindly using gcc. I think that's it.

I will be attaching the diff from the mouseremote-gentoo patch (a diff from a patch.. a bit convoluted.) I will also attach the new mouseremote-gentoo.patch file to make it easier.

I will also be attaching my patch to the Makefile.
Comment 4 Dane Smith (RETIRED) gentoo-dev 2010-08-13 04:19:42 UTC
Created attachment 242703 [details]
The *real* diff from mouseremote-0.90.ebuild

Same comment as above, this time with the correct attachment.
Comment 5 Dane Smith (RETIRED) gentoo-dev 2010-08-13 04:21:00 UTC
Created attachment 242705 [details]
Diff from mouseremote-gentoo.patch

I think a diff from a patch is a little odd myself, but just in case it will make someone's life a little easier, here it is. I'll attach the full modified patch next.
Comment 6 Dane Smith (RETIRED) gentoo-dev 2010-08-13 04:21:41 UTC
Created attachment 242707 [details]
New mouseremote-gentoo.patch

Full patch. This should replace the one currently in the tree.
Comment 7 Dane Smith (RETIRED) gentoo-dev 2010-08-13 04:22:54 UTC
Created attachment 242709 [details]
mouseremote-0.90-makefile.diff

New patch to the Makefile to force LDFLAGS compliance (among other things). Full name is mouseremote-0.90-makefile.diff
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2010-08-13 15:30:42 UTC
+*mouseremote-0.90-r1 (13 Aug 2010)
+
+  13 Aug 2010; Markos Chandras <hwoarang@gentoo.org>
+  +mouseremote-0.90-r1.ebuild, +files/mouseremote-0.90-makefile.diff,
+  files/mouseremote-gentoo.diff:
+  Apply patches from Dane Smith <smithdanea@gmail.com> to respect
+  LDFLAGS,CC, ebuild QA fixes. Bug #331859
+