Bug 331299 – net-im/ejabberd needs openssl's MD2 to compile

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sergey Ilinykh 2010-08-05 10:54:34 UTC]

net-im/ejabberd won't build without openssl's MD2

sha_drv.c:23:25: error: openssl/md2.h: No such file or directory
sha_drv.c: In function 'sha_drv_control':
sha_drv.c:40: error: 'MD2_DIGEST_LENGTH' undeclared (first use in this function)
sha_drv.c:40: error: (Each undeclared identifier is reported only once
sha_drv.c:40: error: for each function it appears in.)
sha_drv.c:42: warning: implicit declaration of function 'MD2'
make[1]: *** [../sha_drv.so] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/net-im/ejabberd-2.1.5/work/ejabberd-2.1.5/src/tls'
make: *** [all-recursive] Error 1


from discussion with one of developers (russian):

[16:31:43] <Rion> а когда ежик будет совместим с openssl-1.0 ?
[16:32:04] <Rion> или для этого какие-то хитрые манипуляции при сборке можно совершить?
[16:32:29] <Rion> просто по-умолчанию опенссл-1.0 собирается без md2
[16:41:09] <xram> md2 нужен для капсов
[16:41:57] <xram> так что это проблема openssl
[16:42:05] <xram> много RFC до сих пор требует md2

Reproducible: Always

Steps to Reproduce:

[Comment 1 Peter Volkov (RETIRED) 2010-08-05 10:59:28 UTC]

According to upstream md2 is required for capses but vendors are about to disable this... I'll report upstream.

[Comment 2 Samuli Suominen (RETIRED) 2010-08-05 11:50:26 UTC]

Created attachment 241493 [details, diff]
Remove MD2 support from ejabberd

Fixes the issue

[Comment 3 Samuli Suominen (RETIRED) 2010-08-05 11:52:12 UTC]

please apply the patch rather sooner than later, bug 330437 is already open...

[Comment 4 Sergey Ilinykh 2010-08-05 12:02:07 UTC]

this patch makes ejabberd incompatible with XEP-0115
read http://xmpp.org/extensions/xep-0115.html
and http://www.iana.org/assignments/hash-function-text-names/hash-function-text-names.xml
(the first link refers to the second one)

i'd suggest to write a letter to XMPP Standards Foundation and ask them to change xep-0115

[Comment 5 Peter Volkov (RETIRED) 2010-08-05 12:04:49 UTC]

(In reply to comment #4)
> this patch makes ejabberd incompatible with XEP-0115

XEP states:

An implementation MAY support other algorithms. Any such algorithm SHOULD be registered in the IANA Hash Function Textual Names Registry [24].

So I don't see any incompatibility... Could you clarify?

[Comment 6 Craig Andrews 2010-08-06 16:16:14 UTC]

Confirmed that the patch works allows ejabberd to compile and work.

[Comment 7 Samuli Suominen (RETIRED) 2010-08-08 03:48:08 UTC]

The upstream bug is fixed.  They added a "openssl/md2.h" check in the configure script and "#ifdef HAVE_MD2" around the code.
The attached patch is still good, since they changed exact same places in the code and we dont need the support anymore.

[Comment 8 Peter Volkov (RETIRED) 2010-08-09 08:22:01 UTC]

Thank you Samuli. I've took upstream patch anyway, since if there are any problems (in other places) with it I'd like to see them earlier then later. This bug is fixed.