Bug 328969 – media-video/vlc-1.1.0 stack smash in qt4 gui

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Tristan Heaven (RETIRED) 2010-07-19 15:03:32 UTC]

#0  0x00007ffff71a3185 in *__GI_raise (sig=<value optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007ffff71a45b0 in *__GI_abort () at abort.c:92
#2  0x00007ffff71ddec7 in __libc_message (do_abort=<value optimized out>, fmt=<value optimized out>)
    at ../sysdeps/unix/sysv/linux/libc_fatal.c:186
#3  0x00007ffff7255dd7 in *__GI___fortify_fail (msg=0x7ffff728e09a "stack smashing detected") at fortify_fail.c:32
#4  0x00007ffff7255da0 in __stack_chk_fail () at stack_chk_fail.c:29
#5  0x00007ffff35719e5 in InputManager::UpdateVout (this=0xaec680) at input_manager.cpp:593
#6  0x00007ffff3573bec in InputManager::setInput (this=0xaec680, _p_input=<value optimized out>) at input_manager.cpp:112
#7  0x00007ffff3676fea in InputManager::qt_metacall (this=0xaec680, _c=QMetaObject::InvokeMetaMethod, 
    _id=<value optimized out>, _a=0x7fffbfe06290) at input_manager.moc.cpp:168
#8  0x00007ffff243f00e in QMetaObject::activate (sender=0xaa9bc0, m=<value optimized out>, 
    local_signal_index=<value optimized out>, argv=0xffffffffffffffff) at kernel/qobject.cpp:3287
#9  0x00007ffff3675ecf in MainInputManager::inputChanged (this=0x4b62, _t1=0xa9f0a0) at input_manager.moc.cpp:472
#10 0x00007ffff3571489 in MainInputManager::customEvent (this=0xaa9bc0, event=<value optimized out>)
    at input_manager.cpp:1048

[Comment 1 Tristan Heaven (RETIRED) 2010-07-19 15:03:49 UTC]

Created attachment 239387 [details, diff]
vlc-1.1.0-stacksmash.patch

[Comment 2 Alexis Ballier 2010-07-19 15:18:22 UTC]

not very verbose on how to reproduce it

please send the patch upstream: http://wiki.videolan.org/Git (section 1.10)

[Comment 3 Tristan Heaven (RETIRED) 2010-07-19 15:29:35 UTC]

(In reply to comment #2)
> not very verbose on how to reproduce it

Just need to compile with -fstack-protector-all and open a video.

[Comment 4 Tristan Heaven (RETIRED) 2010-07-19 15:40:24 UTC]

...on amd64 or other archs where sizeof(size_t) > sizeof(int)

[Comment 5 Alexis Ballier 2010-07-20 06:09:05 UTC]

(In reply to comment #2)
> please send the patch upstream: http://wiki.videolan.org/Git (section 1.10)

this was the most important part of the comment :)

It'll take you 5 mins, you'll retain authorship of the fix and it'll be in 1.1.1. If you don't intend to do it, just say so, I'll send it and steal half of your credits :)

[Comment 6 Tristan Heaven (RETIRED) 2010-07-20 12:03:20 UTC]

sent

[Comment 7 Alexis Ballier 2010-07-21 07:48:12 UTC]

(In reply to comment #6)
> sent
> 

thanks, fixed in >=1.1.1