Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 323379 - media-libs/libcanberra is missing x11-themes/sound-theme-freedesktop RDEPEND
Summary: media-libs/libcanberra is missing x11-themes/sound-theme-freedesktop RDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 23:25 UTC by Daniel Cater
Modified: 2010-09-23 09:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
USE=sound (foo.patch,938 bytes, patch)
2010-09-22 20:55 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cater 2010-06-09 23:25:56 UTC
From bug 314899 comment 51:

I upgraded yesterday after x86 went stable and everything worked well, good
job. However, after doing a depclean, there is no sound theme.
x11-themes/sound-theme-freedesktop was removed. It seems that
=gnome-extra/gnome-media-2.26.0-r1 had a "sound" USE flag and depended on it,
but =gnome-extra/gnome-media-2.28.5 doesn't have that flag and doesn't depend
on it. I'm using a stable x86 system with the
default/linux/x86/10.0/desktop/gnome profile. I think for users of this profile
a sound theme should be installed by default. Please fix this.


Reproducible: Always

Steps to Reproduce:
1. Upgrade gnome
2. emerge --depclean
3. Do things that used to generate sounds
Actual Results:  
Hear no sounds.

Expected Results:  
Hear sounds.
Comment 1 Jens-Uwe Peter 2010-08-23 21:24:12 UTC
Same problem with gnome-media-2.30. On another computer the sound theme is not updated anymore since 0.7 has gone stable a few weeks ago.
Comment 2 Pacho Ramos gentoo-dev 2010-09-01 19:48:18 UTC
I would vote for adding an elog message informing users about having to install x11-themes/sound-theme-freedesktop (or any other sound theme) to get sounds. Other option would be to RDEPEND on it... but since libcanberra doesn't really require it to work, I would prefer to show only a message 
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-02 07:47:00 UTC
I would make it PDEPEND on gnome-control-center or the package providing the sound capplet in gnome since it allows selection of sound themes. Otherwise, libcanberra could be a good choice too.
Comment 4 Pacho Ramos gentoo-dev 2010-09-02 09:21:55 UTC
The reason for me preferring elog message over depending on it is that, for example, in my case I don't use gnome sounds at all (I usually have my speakers muted), but media-libs/libcanberra is still required by some apps (like brasero, sound-juicer...), and then, I want to only have libcanberra but don't need any sound-theme to be present
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-02 09:36:39 UTC
I implied behind a USE flag :)
Comment 6 Pacho Ramos gentoo-dev 2010-09-02 10:01:49 UTC
Looks fine for me
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-09-22 15:51:17 UTC
OK, this is also a problem for Xfce4 with xfce4-settings compiled with USE="sound". If the sound-theme-freedesktop is missing, some of the appearance settings are greyed out by default.

And this is from libcanberra-0.25 sources:

src/sound-theme-spec.c:        if (!(fn = ca_new(char, strlen(prefix) + sizeof("/sounds/")-1 + strlen(name) + sizeof("/index.theme"))))
src/sound-theme-spec.c:        sprintf(fn, "%s/sounds/%s/index.theme", prefix, name);

I would say this bug is not solved before libcanberra by default pulls in the mandatory spec index.theme 
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2010-09-22 16:15:26 UTC
+  22 Sep 2010; Samuli Suominen <ssuominen@gentoo.org>
+  libcanberra-0.25.ebuild:
+  Missing x11-themes/sound-theme-freedesktop RDEPEND which is required for
+  index.theme file wrt #323379 by Daniel Cater.
Comment 9 Pacho Ramos gentoo-dev 2010-09-22 20:06:04 UTC
This doesn't look like the right fix to me:

I have been using libcanberra based apps since required without installing any sound theme (that I don't use at all) and I have not seen any problem, then, I don't understand why it's required by "alsa", "gstreamer"... USE flags instead of adding a "sound" USE flag for installing it allowing people like me to simply disable that one
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2010-09-22 20:55:24 UTC
Created attachment 248391 [details, diff]
USE=sound

Pacho, If you want to apply this, me (or the Xfce4 team) would be fine with.
We don't enable USE=sound by default in xfce4-settings, so I don't really care if it is with or without + flag

If this gets applied, we need to just add USE dep to [sound] in xfce4-settings to ensure the fdo standard index.theme is there.
Comment 11 Pacho Ramos gentoo-dev 2010-09-22 21:23:07 UTC
OK, will take care of this as soon as possible (I hope tomorrow)

Thanks :-)
Comment 12 Pacho Ramos gentoo-dev 2010-09-23 09:13:25 UTC
+  23 Sep 2010; Pacho Ramos <pacho@gentoo.org> -libcanberra-0.11.ebuild,
+  -files/libcanberra-0.14-am-gconf-source-2-m4.patch,
+  -files/libcanberra-0.14-backward-compatibility-libtool.patch,
+  -libcanberra-0.22.ebuild, libcanberra-0.25.ebuild, metadata.xml:
+  Allow people to not RDEPEND on x11-themes/sound-theme-freedesktop
+  unsetting 'sound' USE flag, but turn it on by default for better 'user
+  experience' with Gnome and Xfce desktops (thanks to Samuli Suominen for
+  his patch on bug #323379). Also remove old versions.
+