epiphany-extensions uses automake's maintainer mode feature to enable deprecation flags. As eautoreconf is used, --disable-maintainer-mode should be passed to configure. Otherwise, the deprecation flags will be enabled and the build will fail for newer versions of GTK+ (2.20, in my case). The most recent version of epiphany-extensions (2.30.0) bumped the GTK+ requirement but still uses maintainer mode to enable the deprecation flags, so it could still break at some point. epiphany-extensions-2.28.1-r2 does this right, but 2.22.2, 2.24.3 and 2.24.3-r10 do not (although I have not checked the tarballs to see if maintainer mode is used in those versions).
Created attachment 228405 [details, diff] patch for epiphany 2.26.1-r1 ebuild
Created attachment 228407 [details, diff] better patch
could you provide a build.log showing the issue ?
Feel free to contribute a backward compatible patch like we handled the libxklavier-3.8 -> 4.0 migration, it'll help things go a lot faster. Thanks.
Created attachment 228719 [details] build.log from in-tree epiphany-extensions compiled against gtk+-2.20.0 from gnome overlay (In reply to comment #3) > could you provide a build.log showing the issue ? Sure, and sorry for not attaching this earlier. The build succeeds, but with warnings. At runtime, epiphany fails to start giving this warning (I have the pageinfo extension enabled): epiphany: symbol lookup error: /usr/lib64/epiphany/2.26/extensions/libpageinfoextension.so: undefined symbol: GTK_WIDGET_REALIZED Adding --disable-maintainer-mode fixes both of these issues and I can use epiphany again with gtk+-2.20.0. Let me know if you need any more information. (In reply to comment #4) > Feel free to contribute a backward compatible patch like we handled the > libxklavier-3.8 -> 4.0 migration, it'll help things go a lot faster. Thanks. OK, I will try to get something working this evening. Do you mean some code that looks like: #if GTK_CHECK_VERSION(2, 19, 7) gtk_widget_get_realized(blah); #else GTK_WIDGET_REALIZED(blah); #endif or something more sophisticated?
Created attachment 228813 [details, diff] backwards compatibility patch This patch assumes that the deprecated macros are disabled, and uses the new accessor functions if compiling against gtk+ 2.19.7 and above. Tested successfully with gtk+-2.18.7 and gtk+-2.20.0.
Created attachment 228815 [details, diff] leave maintainer mode alone, just patch sources
With 2.28 being the latest stable, perhaps this can be closed? The 2.30 ebuild seems to do this correctly too.
I vote for simply passing "--disable-maintainer-mode" for 2.26 since I doubt it will be still available when gtk+3 hits the tree
+*epiphany-extensions-2.32.0 (29 Oct 2010) + + 29 Oct 2010; Pacho Ramos <pacho@gentoo.org> + epiphany-extensions-2.26.1-r1.ebuild, + -epiphany-extensions-2.28.1-r2.ebuild, + -files/epiphany-extensions-2.28.1-auto-scroller-broken.patch, + +epiphany-extensions-2.32.0.ebuild: + Version bump for Gnome 2.32: Remove deprecated GTK+ symbols, update + html5tube extension to handle the latest youtube layout changes. Let it + build when having python3 as default interpreter. Pass + --disable-maintainer-mode to 2.26 since it is still needed for ppc64. + Remove old testing. +
