Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311629 - dev-util/pkgcheck: should check for proper ssl use flag usage
Summary: dev-util/pkgcheck: should check for proper ssl use flag usage
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-27 14:44 UTC by Petteri Räty (RETIRED)
Modified: 2022-07-12 03:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2010-03-27 14:44:26 UTC
If a package only supports a single crypto backend, then the use flag should be named ssl instead of after the implementation. Use flags are about functionality not how they are implemented. Checks to add:

1) if a package has gnutls,openssl or nss use flag then there should also be a ssl use flag

2) If there's only one of gnutls, openssl and nss use flags and no ssl use flag, then tell the developer to rename the use flag to ssl
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2010-03-27 15:01:33 UTC
14:59 <@Arfrever> Betelgeuse: Some packages support multiple SSL backends and don't support installation without SSL support, so they might not need "ssl" USE flag...
15:01 <@Betelgeuse> Arfrever: Ok then it's ok to have multiple implementation flags without USE="ssl"
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-26 18:28:54 UTC
AFAIK OpenSSL and nss can be used as a crypto backend without SSL use.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2010-09-29 18:30:53 UTC
(In reply to comment #2)
> AFAIK OpenSSL and nss can be used as a crypto backend without SSL use.
> 

Then the correct use flag name is "crypt".
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-29 18:43:14 UTC
(In reply to comment #3)
> Then the correct use flag name is "crypt".

Then repoman should complain check for 'crypt' as well, and complain only if neither ssl nor crypt is in USE besides openssl.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:32 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.