Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 306203 - rox.eclass - make_desktop_entry uses deprecated stuff
Summary: rox.eclass - make_desktop_entry uses deprecated stuff
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Rox Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-21 15:41 UTC by Doktor Notor
Modified: 2010-03-10 09:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doktor Notor 2010-02-21 15:41:29 UTC
The Encoding key has been deprecated for quite a while*, this needs some syncing w/ eutils.eclass ;)

*http://standards.freedesktop.org/desktop-entry-spec/latest/
Comment 1 SpanKY gentoo-dev 2010-03-07 03:01:36 UTC
yes, copying & pasting make_desktop_entry instead of enhancing the common code is stupid
Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev 2010-03-07 20:44:33 UTC
Stupid?  Yes, that's what I thought at first too.

If I recall correctly (it was a while ago, so it's a bit foggy), I chatted with
someone on IRC about this very fact.  I wanted the eutils 'make_desktop_entry'
to let me specify a 'MimeType=' entry in my desktop file, but was told that they
didn't want to support every little possible field in eutils.eclass, so I was on
my own.  So I did it myself.  But my first instinct was indeed to extend the
common code to do this the right way!

If you want to come up with a way to let me set the MimeType field using the
eutils.eclass, I'd very happily use that function instead.  Or feel free to
just add the little snippet I use, which just appends any extra arguments given
to my desktop function into the .desktop file automatically:

    local extra=${1}; shift
    while [[ "${extra}" ]]; do
        echo "${extra}" >> "${desktop}"
        extra=${1}; shift
    done

For example, that lets me just append "MimeType=text/plain" on the end and have
that show up in the Desktop file, but any way to let me send in a list of
MimeType arguments is all I really need.

Until you or I or someone else comes up with a good general solution in
eutils.eclass, I have removed the Encoding and Version lines from the rox.eclass
version.
Comment 3 Doktor Notor 2010-03-10 09:48:40 UTC
Well, enhancing eutils.eclass to deal with mime types etc. is beyond the scope of this bug. This one was merely about generating .desktop files conforming to FDO specs. So... FIXED ;) Thanks.