Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 304373 - x11-misc/fbpanel-5.6: locale issues
Summary: x11-misc/fbpanel-5.6: locale issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 19:30 UTC by Harald van Dijk (RETIRED)
Modified: 2010-03-25 21:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild applying patch (fbpanel-6.0.ebuild,682 bytes, text/plain)
2010-03-25 18:39 UTC, Samuli Suominen (RETIRED)
Details
patch for above ebuild (fbpanel-6.0-configure-LANG.patch,529 bytes, patch)
2010-03-25 18:40 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald van Dijk (RETIRED) gentoo-dev 2010-02-10 19:30:22 UTC
1) With LC_MESSAGES (or just LANG) set, for example to ru_RU.UTF-8, but plenty of others, the configure step aborts:

>>> Configuring source in /var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6 ...
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64
Default value of 'endianess' couldn't be set from '`scripts/endianess.sh`'
Set it explicitly with '--endianess=value'
 * ERROR: x11-misc/fbpanel-5.6 failed:
 *   econf failed

2) The scripts/endianess.sh mentioned above is a script that besides assuming all the world's English, also assumes anything that's not x86 is big-endian. This is wrong for at least arm, probably also alpha. However, this might only be cosmetic: I cannot find any part of the code that actually checks the endianness.

3) With LC_CTYPE set to tr_TR.UTF-8, the configure passes, but the build aborts due to incorrect tr usage in the configure script:

>>> Compiling source in /var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6 ...
make -j1 
make[1]: Entering directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins'
make[2]: Entering directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins/dclock'
x86_64-pc-linux-gnu-gcc -march=native -ggdb -O2 -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -M dclock.c | sed 's,\(.*\)\.o[ :]*,./\1.o dclock.d : ,g' > dclock.d
dclock.c:13:18: fatal error: misc.h: No such file or directory
compilation terminated.
make[2]: Leaving directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins/dclock'
make[2]: Entering directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins/dclock'
x86_64-pc-linux-gnu-gcc -march=native -ggdb -O2 -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -Wall -I -I/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/panel -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -fPIC -c -o dclock.o dclock.c
dclock.c:13:18: fatal error: misc.h: No such file or directory
compilation terminated.
make[2]: *** [dclock.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins/dclock'
make[1]: *** [dclock] Error 2
make[1]: Leaving directory `/var/tmp/portage/x11-misc/fbpanel-5.6/work/fbpanel-5.6/plugins'
make: *** [plugins] Error 2
 * ERROR: x11-misc/fbpanel-5.6 failed:
 *   died running emake, base_src_make:make

emerge --info:

Portage 2.2_rc62 (unavailable, gcc-4.5.0-alpha20100204, glibc-2.11-r1, 2.6.33-rc7 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.33-rc7-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_4200+-with-gentoo-2.0.1
Timestamp of tree: Wed, 10 Feb 2010 17:45:03 +0000
app-shells/bash:     4.0_p37
dev-java/java-config: 2.1.10
dev-lang/python:     2.6.4-r1
dev-util/cmake:      2.8.0-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.0-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20
sys-devel/gcc:       4.4.3, 4.5.0_alpha20100204
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -ggdb -O2"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -ggdb -O2"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--noconfmem --oneshot --verbose --with-bdeps=y"
FEATURES="assume-digests autopatch fixpackages news notitles preserve-libs protect-owned sandbox sfperms sign splitdebug strict test test-fail-continue unmerge-logs unmerge-orphans userfetch userpriv"
GENTOO_MIRRORS="http://distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Xlinker -O1 -Xlinker --as-needed"
LINGUAS="*"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/etc/portage/layman/java-overlay /etc/portage/layman/sunrise /etc/portage/layman/toolchain /etc/portage/crossdev /etc/portage/overlay /var/cvs/gentoo-x86"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac accessibility acl acpi ads alsa amd64 apache2 aspell berkdb bindist bzip2 cairo cdda cdparanoia cdr cjk cli consolekit cracklib crypt cups cvs dbus demo dri dts dvd dvdr eds emboss encode evo fam ffmpeg firefox flac fts3 gcj gdbm gif git gnome gnome-keyring gnutls gstreamer gtk iconv inotify ipv6 ithreads java java5 java6 javascript jit jpeg kvm latex lcms ldap mad mbox mikmod mmx mmxext mng mp3 mp4 mpeg mudflap multilib ncurses nls nocxx normalize nptl nptlonly nsplugin ntfs ogg opengl openmp optimized-qmake oss pam pcre pdf pdo perl pg_legacytimestamp pic png postgres ppds pppd preview-latex python qt3support qt4 quicktime radio rdp readline reflection samba samba4 sdl session smbclient spell spl sql sqlite sse sse2 ssl startup-notification subversion svg swat symlink sysfs tcl tcpd theora threads thunar tidy tiff timidity tk tokenizer toolkit-scroll-bars truetype udev unicode usb v4l v4l2 vhosts videos vim-syntax vorbis webkit x264 xattr xcomposite xml xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="*" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="nouveau nv vesa" 
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

x11-misc/fbpanel-5.6 was built with the following:
USE="(multilib) test" ELIBC="glibc" KERNEL="linux" USERLAND="GNU"
Comment 1 Anatoly 2010-02-14 10:00:31 UTC
Can you attach an ebuild, please.
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2010-02-14 12:48:57 UTC
The ebuild can be seen at http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-misc/fbpanel/fbpanel-5.6.ebuild?rev=1.1&view=markup

But it is very basic. It uses our base eclass, which essentially just runs ./configure && make && make install
Comment 3 Martin Regner 2010-02-25 09:01:50 UTC
As mentioned in the error message i added the following:

src_configure() {
    local myconf="--endianess=LITTLE"

    econf ${myconf}
}

to an overlay ebuild.

The value LITTLE i found somewhere else.
No it compiles and works. But i think this is'nt the right way.
I think this endianess value should be provided by the environment. But
i don't know what it realy means and where to set it right.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 15:51:03 UTC
try 6.0
Comment 5 Harald van Dijk (RETIRED) gentoo-dev 2010-03-25 18:33:46 UTC
6.0 no longer calls endianess.sh, so that takes care of the first two problems. It still fails on #3 though.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 18:39:50 UTC
Created attachment 225237 [details]
ebuild applying patch
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 18:40:08 UTC
Created attachment 225239 [details, diff]
patch for above ebuild
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 18:40:26 UTC
(In reply to comment #5)
> 6.0 no longer calls endianess.sh, so that takes care of the first two problems.
> It still fails on #3 though.
> 

try the attachments please.
Comment 9 Anatoly 2010-03-25 19:03:16 UTC
with LC_CTYPE=tr_TR.UTF-8 ./configure generates config.mk with wrong variable names - they all caps besides 'i' which is lower case, e.g
PREFiX = /home/anatoly/.local/
EPREFiX = /home/anatoly/.local/
BiNDiR = /home/anatoly/.local//bin
SBiNDiR = /home/anatoly/.local//sbin
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 19:06:23 UTC
even with the above patch?? it should reset LC_CTYPE to C if defined
Comment 11 Anatoly 2010-03-25 19:45:25 UTC
I mean that's why unpatched configure does not work. BTW, gnu autoconf has this code in a its configure script
# NLS nuisances.
LC_ALL=C
export LC_ALL
LANGUAGE=C
export LANGUAGE

and it solves the problem as well. I'll commit it to fbpanel source 
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 19:48:49 UTC
(In reply to comment #11)
> I mean that's why unpatched configure does not work. BTW, gnu autoconf has this
> code in a its configure script
> # NLS nuisances.
> LC_ALL=C
> export LC_ALL
> LANGUAGE=C
> export LANGUAGE
> 
> and it solves the problem as well. I'll commit it to fbpanel source 
> 

oh, don't do that or you will break portability of fbpanel. use the patch attached here. 

only set these to C if already set. those must not be set unconditionally because not all systems understand e.g. LANG=C (notably SCO).
and fixing LC_MESSAGES prevents solaris sh from translating var values in `set'!

Comment 13 Anatoly 2010-03-25 20:05:41 UTC
Thanks for pointing that. I've commited your patch 
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2010-03-25 20:09:57 UTC
+  25 Mar 2010; Samuli Suominen <ssuominen@gentoo.org> fbpanel-6.0.ebuild,
+  +files/fbpanel-6.0-configure-LANG.patch:
+  Reset language vars to C in ./configure wrt #304373 by Harald van Dijk.
Comment 15 Harald van Dijk (RETIRED) gentoo-dev 2010-03-25 21:18:27 UTC
Thanks, it builds, installs and runs now.