Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 303028 - ~net-libs/xulrunner-1.9.2 and mail-client/mozilla-thunderbird-3* don't use system sqlite
Summary: ~net-libs/xulrunner-1.9.2 and mail-client/mozilla-thunderbird-3* don't use sy...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: InVCS
Depends on: 303058
Blocks:
  Show dependency tree
 
Reported: 2010-01-31 21:14 UTC by Rafał Mużyło
Modified: 2010-02-12 20:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2010-01-31 21:14:02 UTC
The dep is there, but the configure.in defaults to the shipped copy,
if '--enable system-sqlite' is not given.
Comment 1 Rafał Mużyło 2010-02-01 02:57:50 UTC
...and on that note: if you fix it by adding '--enable system-sqlite'
in correct places and users start reporting crashes,
don't try to fix it by disabling it again.

In that case, it will be probably something like bug 299390
- so a clean profile should help.
There's of course a matter of loosing your settings,
but perhaps this can be worked around like in that bug.
Comment 2 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-02-02 07:09:19 UTC
(In reply to comment #1)
> ...and on that note: if you fix it by adding '--enable system-sqlite'
> in correct places and users start reporting crashes,
> don't try to fix it by disabling it again.
> 

Quite the contrary, I don't see the point in enabling system sqlite at all if such problems keep arising. Upstream does a barrage of automated and human tests with the shipped version of sqlite (built with specific options, CFLAGS, etc). If we don't use that; the shot in our foot is inevitable.

> In that case, it will be probably something like bug 299390
> - so a clean profile should help.
> There's of course a matter of loosing your settings,
> but perhaps this can be worked around like in that bug.
> 

Losing your profile and/or settings is completely unacceptable. Workarounds are OK, but they destroy the user experience.

To be completely honest, I give much higher value to not pissing the user off. Would it not be a relief to be able to upgrade firefox without fear?
Comment 3 Rafał Mużyło 2010-02-02 12:27:57 UTC
On one hand, user experience is important, but on the other...

I've been using system sqlite with xulrunner:1.9 and firefox-3.0
nearly the whole time it was on my system (even while in-tree
ebuild disabled them) and never got those mysterious sqlite related crashes,
so I'm getting a distinct "the problem lies elsewhere" feeling about
such "solution".

And on that note: sqlite dep in thunderbird-3.* ebuilds is too low
- judging by a lower level configure.in and an other part of the build
process, it probably needs the same as xulrunner (specifically useflag).
Comment 4 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2010-02-11 08:39:43 UTC
Looks like Jory wants it. What gives?
Comment 5 Jory A. Pratt gentoo-dev 2010-02-12 20:54:50 UTC
This is fixed, the reason we are sticking with system sqlite is the fact we have finally worked out the problems introduced by buggy sqlite versions. The dep on xulrunner-1.9.2/firefox-3.6 is that of the current development tree upstream. It is a perfect match across the board and works just as it is expected to.