Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 297174 - app-portage/gentoolkit: revdep-rebuild niceness problem
Summary: app-portage/gentoolkit: revdep-rebuild niceness problem
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 237964 305793
  Show dependency tree
 
Reported: 2009-12-16 15:15 UTC by Arthur D.
Modified: 2010-02-18 18:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for gentoolkit-0.2.4.5 (revdep-rebuild.297174.gentoolkit-0.2.4.5.patch,807 bytes, patch)
2009-12-17 15:48 UTC, Paul Varner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur D. 2009-12-16 15:15:08 UTC
Hello.
I have my X server environment running with nice level of 10 (the reason for doing this is explained here: http://bugs.gentoo.org/show_bug.cgi?id=285764). All my desktop applications (including terminals) inherit the nice level of 10. When I run "emerge something..." I get it running with the nice level of 15, which is correct, because I have PORTAGE_NICENESS=5 option set in /etc/make.conf (resulting niceness: 10+5 = 15). And my system remains quite usefull: I can watch movies and do my work well without much delays, because of high CPU load.

When I run revdep-rebuild I'm getting emerge nice level of 10.
It seems that revdep-rebuild sets it's nice level to absolute value of 5 from PORTAGE_NICENESS variable value, and then it runs emerge, which adds 5 more to niceness. That's the wrong behaviour. The resulting niceness should be calculated as 10+5 (and probably +5 for emerge), but not as 0+5+5.

I hope I explained well what's wrong with it. Sorry for my English.

Reproducible: Always

Steps to Reproduce:
Comment 1 Paul Varner (RETIRED) gentoo-dev 2009-12-17 15:46:22 UTC
$ svn commit -m "Fix revdep-rebuild to properly honor PORTAGE_NICENESS as an incremental to the current nice level. (Bug 297174)"
Sending        gentoolkit/ChangeLog                
Sending        gentoolkit/bin/revdep-rebuild       
Transmitting file data ..                        
Committed revision 724.                              
Comment 2 Paul Varner (RETIRED) gentoo-dev 2009-12-17 15:48:10 UTC
Created attachment 213300 [details, diff]
Patch for gentoolkit-0.2.4.5

This is the patch for gentoolkit-0.2.4.5
Comment 3 Arthur D. 2009-12-17 17:32:49 UTC
The patch works nice. Thanks.
Comment 4 Paul Varner (RETIRED) gentoo-dev 2010-01-07 16:33:46 UTC
Released in gentoolkit-0.3.0_rc8