Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 296606 - =xfce-base/xfce-utils-4.6.1 xinitrc replaces gnome-keyring SSH_AUTH_SOCK with ssh-agent
Summary: =xfce-base/xfce-utils-4.6.1 xinitrc replaces gnome-keyring SSH_AUTH_SOCK with...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: XFCE Team
URL: http://bugzilla.xfce.org/show_bug.cgi...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-12 13:11 UTC by Michał Górny
Modified: 2010-10-24 20:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix the issue (xfce-utils-4.6.1-sshagent-gkr-conflict.diff,665 bytes, patch)
2009-12-12 13:16 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-12 13:11:08 UTC
/etc/xdg/xfce4/xinitrc installed by =xfce-base/xfce-utils-4.6.1 starts ssh-agent automatically on xfce startup, even if gnome-keyring is already running as a SSH agent (started by PAM). This way, ssh-agent replaces SSH_AUTH_SOCK set by gkr which is unintended.

As a solution, I suggest to add a check for SSH_AUTH_SOCK along with SSH_AGENT_PID (which isn't set by gkr).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-12 13:16:17 UTC
Created attachment 212772 [details, diff]
Patch to fix the issue
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-12-12 13:39:03 UTC
Report it also to http://bugzilla.xfce.org/ as it's upstream file we are installing, not a custom Gentoo one and link us there. Thanks.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-05-12 21:13:34 UTC
Michal, have you been able to post upstream yet? Thanks.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-05-13 04:03:38 UTC
(In reply to comment #3)
> Michal, have you been able to post upstream yet? Thanks.

Yes, the appropriate thread is linked in 'URL' field.
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-05-27 02:43:15 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Michal, have you been able to post upstream yet? Thanks.
> 
> Yes, the appropriate thread is linked in 'URL' field.
> 

Sorry, I missed that! If upstream doesn't support the idea, we don't really want to maintain it in Gentoo. I hope you understand.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-10-24 20:18:48 UTC
Upstream bug was fixed, I've snatched the patch from git to xfce4-session-4.7.0 (but won't backport it to 4.6.x).

+  24 Oct 2010; Samuli Suominen <ssuominen@gentoo.org>
+  xfce4-session-4.7.0.ebuild,
+  +files/xfce4-session-4.7.0-gnome-keyring.patch:
+  Fix gnome-keyring initialization wrt #296606 by Michał Górny.