Bug 291666 – gnome-extra/gnome-color-manager ebuild request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrey Ovcharov 2009-11-03 09:12:10 UTC]

http://projects.gnome.org/gnome-color-manager/
"GNOME Color Manager is a session framework for the GNOME desktop environment that makes it easy to manage easy to manage, install and generate color profiles."

[Comment 1 Andrey Ovcharov 2009-12-09 13:24:26 UTC]

http://github.com/init6/init_6/blob/master/gnome-extra/gnome-color-manager/gnome-color-manager-2.29.1.ebuild

[Comment 2 Andrey Ovcharov 2009-12-09 13:25:07 UTC]

Created attachment 212535 [details]
gnome-extra/gnome-color-manager/gnome-color-manager-2.29.1.ebuild

[Comment 3 Account removed 2009-12-27 08:19:52 UTC]

Created attachment 214265 [details]
gnome-extra/gnome-color-manager-2.29.1.ebuild 

Corrected dependencies

[Comment 4 Andrew Muhametshin 2010-01-04 22:27:11 UTC]

#
  CC     gcm_import-gcm-import.o
#
In file included from /usr/include/unique-1.0/unique/uniqueapp.h:27,
#
                 from /usr/include/unique-1.0/unique/unique.h:24,
#
                 from gcm-prefs.c:27:
#
/usr/include/gtk-2.0/gtk/gtkwindow.h:28:2: error: #error "Only <gtk/gtk.h> can be included directly."
#
In file included from /usr/include/unique-1.0/unique/uniquebackend.h:26,
#
                 from /usr/include/unique-1.0/unique/unique.h:25,
#
                 from gcm-prefs.c:27:
#
/usr/include/gtk-2.0/gdk/gdkscreen.h:25:2: error: #error "Only <gdk/gdk.h> can be included directly."
#
make[3]: *** [gcm_prefs-gcm-prefs.o] Error 1


build.log: http://pastebin.ca/1737991
emere --info: http://pastebin.ca/1737995

[Comment 5 Romain Perier (RETIRED) 2010-01-05 12:31:05 UTC]

(In reply to comment #4)
> #
>   CC     gcm_import-gcm-import.o
> #
> In file included from /usr/include/unique-1.0/unique/uniqueapp.h:27,
> #
>                  from /usr/include/unique-1.0/unique/unique.h:24,
> #
>                  from gcm-prefs.c:27:
> #
> /usr/include/gtk-2.0/gtk/gtkwindow.h:28:2: error: #error "Only <gtk/gtk.h> can
> be included directly."
> #
> In file included from /usr/include/unique-1.0/unique/uniquebackend.h:26,
> #
>                  from /usr/include/unique-1.0/unique/unique.h:25,
> #
>                  from gcm-prefs.c:27:
> #
> /usr/include/gtk-2.0/gdk/gdkscreen.h:25:2: error: #error "Only <gdk/gdk.h> can
> be included directly."
> #
> make[3]: *** [gcm_prefs-gcm-prefs.o] Error 1
> 
> 
> build.log: http://pastebin.ca/1737991
> emere --info: http://pastebin.ca/1737995
> 

The fix is pretty simple to write, apparently gcm-prefs.c includes gtkwindow.h directly which is bad (if some headers are renamed due to an API change for example), you've just to replace it by a :
#include <gtk/gtk.h>

same thing for gdkscreen.h (replace it by gdk/gdk.h)

:)

[Comment 6 Hicham HAOUARI 2010-01-26 16:54:25 UTC]

updating libunique to 1.1.x fixes the problem

[Comment 7 Milos Popovic 2010-08-18 13:08:57 UTC]

We should bump this into gnome overlay for testing. Gnome-color-manager is now listed into default gnome application. Lastest version is 2.31.6.

[Comment 8 Diego Elio Pettenò (RETIRED) 2010-11-19 12:17:50 UTC]

I'm interested in this myself, I picked up the ebuild and reworked it a bit, but there is an automagic dep on sane that will require met o patch it before pushing it anywhere.

[Comment 9 Gilles Dartiguelongue (RETIRED) 2010-11-19 13:00:53 UTC]

for the record, there is an ebuild for 2.32 in the gnome overlay. I forgot to update this report afterwards.

[Comment 10 Diego Elio Pettenò (RETIRED) 2010-11-19 13:08:02 UTC]

Ah fun — I found the commit upstream used to make sane optional though and it's not nice.

Gnome team, any misgiving if I were to import this into maintree?

[Comment 11 Gilles Dartiguelongue (RETIRED) 2010-11-19 13:15:33 UTC]

nope, it's fine, you can add us a backup herd if you wish.

[Comment 12 Diego Elio Pettenò (RETIRED) 2010-11-19 13:25:43 UTC]

In tree now :)

[Comment 13 Serge Gavrilov 2010-11-19 17:10:00 UTC]

What about ~x86?