Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289904 - nicotine+ ebuild with miniupnpc support
Summary: nicotine+ ebuild with miniupnpc support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Ryan Hill (RETIRED)
URL: http://www.nicotine-plus.org/
Whiteboard:
Keywords: EBUILD
Depends on: 241120
Blocks:
  Show dependency tree
 
Reported: 2009-10-20 19:22 UTC by George Kargiotakis
Modified: 2010-12-21 04:27 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
miniupnpc 20091016 (miniupnpc-20091016.ebuild,654 bytes, text/plain)
2009-10-20 19:22 UTC, George Kargiotakis
Details
nicotine-1.2.14 ebuild with upnp use flag (nicotine+-1.2.14-r1.ebuild,1004 bytes, text/plain)
2009-10-20 19:23 UTC, George Kargiotakis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description George Kargiotakis 2009-10-20 19:22:11 UTC
New ebuild for nicotine+-1.2.14 with upnp use flag (miniupnpc dep)

Reproducible: Always

Steps to Reproduce:




Used https://bugs.gentoo.org/show_bug.cgi?id=273459 ase a base for miniupnpc ebuild.
Comment 1 George Kargiotakis 2009-10-20 19:22:58 UTC
Created attachment 207717 [details]
miniupnpc 20091016
Comment 2 George Kargiotakis 2009-10-20 19:23:45 UTC
Created attachment 207718 [details]
nicotine-1.2.14 ebuild with upnp use flag
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-08-21 09:38:49 UTC
I personally dislike adding USEflags for RDEPENDs only. This has the following disadvantages:
1) if one of these USEflags are changed, PM unnecessarily tries to rebuild the package, while the only required operation would be to adjust the deps;
2) the binary (.tbz2) packages built from the ebuild are bound to a specific USEflag configuration while in fact it doesn't matter,
3) the USEflags work similarly to automagic dependencies -- if a specific USE flag isn't set but the dependency is installed, the particular feature is used anyway.

This is why I suggest to add a note of 'install the additional package for a feature' kind to pkg_postinst() instead. At least, until some new EAPI introduces a smarter kind of runtime-USE.
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2010-12-21 04:27:02 UTC
In 1.2.16 the dependencies are removed in favour of a pkg_postinst() message.