Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289744 - nvidia-settings-190.40 does not compile w/ libXxf86vm-1.1.0 (patch included)
Summary: nvidia-settings-190.40 does not compile w/ libXxf86vm-1.1.0 (patch included)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Piotr Jaroszyński (RETIRED)
URL:
Whiteboard:
Keywords:
: 290885 291433 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-19 15:16 UTC by Matthias Dahl
Modified: 2009-11-19 21:41 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libXxf86vm-1.1.0 compatibility patch (xf86vm-1.1.patch,527 bytes, patch)
2009-10-19 15:16 UTC, Matthias Dahl
Details | Diff
ebuild modified to apply the patch (nvidia-settings-190.42.ebuild,1.96 KB, text/plain)
2009-10-28 13:21 UTC, Paolo Pedroni
Details
libXxf86vm-1.1.0 compatibility patch (rev. b) (libXxf86vm-1.1-compat.patch,597 bytes, patch)
2009-11-01 09:30 UTC, Matthias Dahl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Dahl 2009-10-19 15:16:07 UTC
Summary says it all. Patch is attached.

Reproducible: Always
Comment 1 Matthias Dahl 2009-10-19 15:16:53 UTC
Created attachment 207559 [details, diff]
libXxf86vm-1.1.0 compatibility patch
Comment 2 Piotr Jaroszyński (RETIRED) gentoo-dev 2009-10-22 05:32:34 UTC
The problem with that patch is that the header is not present in earlier versions of libXxf86vm.

Have you contacted upstream about this problem?
Comment 3 David Pyke 2009-10-23 18:49:40 UTC
Patch worked for me.
Comment 4 Paolo Pedroni 2009-10-26 15:35:26 UTC
Patch worked for me as well.
Comment 5 Jonathan Heaney 2009-10-27 19:15:49 UTC
I'm trying this with 190.42 (unmasked due to xorg-server-1.7.1 going ~arch) - can't get the patch to apply - how are you guys going about it here?
Comment 6 Paolo Pedroni 2009-10-28 13:20:51 UTC
(In reply to comment #5)
> I'm trying this with 190.42 (unmasked due to xorg-server-1.7.1 going ~arch) -
> can't get the patch to apply - how are you guys going about it here?

It worked fine for me. I will attach the modified ebuild I've put in my local overlay: just put it in '/usr/local/portage/media-video/nvidia-settings/', put the above patch in '/usr/local/portage/media-video/nvidia-settings/files/' and copy the 'icon' folder from /usr/portage/media-video/nvidia-settings/files/' to '/usr/local/portage/media-video/nvidia-settings/files/' (I'm not even sure this last step is really necessary). Then run (as root) 'ebuild /usr/local/portage/media-video/nvidia-settings/nvidia-settings-190.42.ebuild manifest' and you're good to go emerging nvidia-settings from your local overlay.
Comment 7 Paolo Pedroni 2009-10-28 13:21:37 UTC
Created attachment 208516 [details]
ebuild modified to apply the patch
Comment 8 Jonathan Heaney 2009-10-28 20:10:15 UTC
(In reply to comment #7)
> Created an attachment (id=208516) [details]
> ebuild modified to apply the patch
> 

Thanks, that's worked.
Comment 9 i.Dark_Templar 2009-10-29 21:15:49 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Created an attachment (id=208516) [details] [details]
> > ebuild modified to apply the patch
> > 
> 
> Thanks, that's worked.
> 

Thanks, that's worked for me too
Comment 10 Leonard Khoo 2009-10-30 09:21:15 UTC
update upstream and commit to tree please? Thanks.
Comment 11 Uros 2009-10-31 23:50:24 UTC
(In reply to comment #7)
> Created an attachment (id=208516) [details]
> ebuild modified to apply the patch
> 

Works here also.
Comment 12 Justin Lecher (RETIRED) gentoo-dev 2009-11-01 08:38:45 UTC
*** Bug 290885 has been marked as a duplicate of this bug. ***
Comment 13 Matthias Dahl 2009-11-01 09:30:07 UTC
Created attachment 208926 [details, diff]
libXxf86vm-1.1.0 compatibility patch (rev. b)

Sorry for my late reply but I have been very busy lately w/ life. :-( This patch should work w/ both newer and older libXxf86vm versions.

I have not yet informed upstream about this because of my lack of time. But my guess is they already know and will have a fix of their own in the next release.
Comment 14 Siuchung Cheung (Clement) 2009-11-01 10:16:06 UTC
FYI, upstream says not their fault... :-(
<http://www.nvnews.net/vbulletin/showthread.php?t=140139>
Comment 15 Samuli Suominen (RETIRED) gentoo-dev 2009-11-01 12:18:14 UTC
Oops. Fixed this first without looking at this bug, but updated the patch now to reflect the latest attached one.

Thanks!
Comment 16 Chris Reffett (RETIRED) gentoo-dev Security 2009-11-01 18:43:05 UTC
*** Bug 291433 has been marked as a duplicate of this bug. ***
Comment 17 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-11-01 22:32:55 UTC
*** Bug 291482 has been marked as a duplicate of this bug. ***
Comment 18 Benjamin Schindler 2009-11-03 08:27:58 UTC
This patch breaks build against stable xorg. I have 

x11-libs/libXxf86vm-1.0.2

installed. It does not have the proto header and thus won't build

x86_64-pc-linux-gnu-gcc -c -O3 -pipe -march=native -Wall -O -DNDEBUG -I/usr/X11R6/include -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I doc -I src -I src/image_data -I src/xpm_data -I src/gtk+-2.x -I src/libXNVCtrl -I src/libXNVCtrlAttributes -I src/XF86Config-parser -I samples src/libXNVCtrlAttributes/NvCtrlAttributesGlx.c -o .objs/NvCtrlAttributesGlx.o                                                                            
src/libXNVCtrlAttributes/NvCtrlAttributesVidMode.c:32:40: error: X11/extensions/xf86vmproto.h: No such file or directory
Comment 19 Nick Malakhov 2009-11-03 12:46:50 UTC
(In reply to comment #18)
> src/libXNVCtrlAttributes/NvCtrlAttributesVidMode.c:32:40: error:
> X11/extensions/xf86vmproto.h: No such file or directory
> 

I've solved this problem for me by creating symlink:

# ls -l xf86vmproto.h
lrwxrwxrwx 1 root root 11 Nov  3 15:10 xf86vmproto.h -> xf86vmode.h
# pwd
/usr/include/X11/extensions

It's a temporary way, sure
Comment 20 hirakendu 2009-11-19 21:41:58 UTC
@ comment #19, thanks for the temporary fix by symlinking.