Bug 286254 – media-video/avidemux-2.5.1-r1 fails with ‘vector’ was not declared

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dominik Kapusta (RETIRED) 2009-09-24 15:55:19 UTC]

Dear ppc team,

please keyword avidemux-2.5.1-r1 once opencore-amr is keyworded.

Thanks :)

[Comment 1 Mounir Lamouri (volkmar) (RETIRED) 2009-09-26 22:31:16 UTC]

Created attachment 205346 [details]
Build log

I tried to build it with:
USE=""alsa gtk mp3 nls opencore-amr sdl truetype vorbis xv xvid -aac -aften -dts -esd -jack -libsamplerate -oss -pulseaudio -qt4 -x264"
and it fails miserably...

(opencore is keyworded now, btw)

[Comment 2 Dominik Kapusta (RETIRED) 2009-09-27 10:36:45 UTC]

That's because avidemux seems to require >=cmake-2.6.4 to be built correctly (according to bug #281560). At least it fails for me the same way with cmake-2.6.2 (on amd64, but still). I added the missing dependency, please check if it helps.

[Comment 3 Mounir Lamouri (volkmar) (RETIRED) 2009-09-27 21:34:45 UTC]

Created attachment 205415 [details]
Build log

cmake-2.6.4 has fixed the previous issue but now i got a new one... enjoy :)

[Comment 4 Dominik Kapusta (RETIRED) 2009-09-27 22:27:01 UTC]

Created attachment 205422 [details]
Patch to fix MSmooth plugin compilation

Nice one, didn't see it before... Looks like missing #include <vector> - it's not there, but it's not there also for my amd64 build, which compiles this plugin successfully.

The patch is just my quick guess, it may or may not fix the build. If it doesn't solve the issue, then PPC team ...help?

[Comment 5 Ben de Groot (RETIRED) 2009-10-02 17:43:23 UTC]

Dropping ppc keyword was not needed, a temporary useflag mask would have been better. Anyway, as opencore-amr has been keyworded in the meantime, I restored the ppc keyword. 

This leaves us with the compile error reported, and the proposed patch. PPC team can you please test this for 2.5.1-r2 (which is a possible stable candidate)? Also, can you test the new snapshot 2.5.1_p5359 and see if the same bug appears?

[Comment 6 Mounir Lamouri (volkmar) (RETIRED) 2009-10-02 18:53:15 UTC]

Sorry, I forget to give feedback here but the patch didn't work. Actually, it's failing in a part of the code only available for altivec-enabled processor (ie. ppc): plugins/ADM_videoFilters/MSmooth/ADM_vidMsmooth.cpp line 379

I think it should be good to report the bug upstream.

[Comment 7 Ben de Groot (RETIRED) 2010-03-29 21:11:16 UTC]

Is this bug still present in 2.5.2?

[Comment 8 Joe Jezak (RETIRED) 2010-06-03 14:44:23 UTC]

A different bug showed up in 2.5.2. I've fixed the issue, but perhaps you'd like to send it upstream for me? It's pretty simple, bool was already defined by altivec.h, but being redefined as locBool by the mjpeg_types.h file. I just made this conditional on HAVE_ALTIVEC_H and it works properly.

[Comment 9 Joe Jezak (RETIRED) 2010-06-03 14:45:12 UTC]

Created attachment 233981 [details, diff]
Patch for altivec/bool issue in 2.5.2