Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278953 - sys-apps/dbus FEATURES misuse (test)
Summary: sys-apps/dbus FEATURES misuse (test)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords: QAcanfix
Depends on: 297031
Blocks: 174335
  Show dependency tree
 
Reported: 2009-07-24 18:54 UTC by Thilo Bangert (RETIRED) (RETIRED)
Modified: 2010-09-09 23:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-07-24 18:54:31 UTC
The above package has been found to use FEATURES in at least one of its ebuilds.

affected ebuilds:
dbus-1.0.2-r2.ebuild:   hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"
dbus-1.1.20.ebuild:     hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"
dbus-1.1.4.ebuild:      hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"
dbus-1.2.12.ebuild:             ewarn "It is recommended that you reinstall *without* FEATURES=test"
dbus-1.2.1.ebuild:      hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"
dbus-1.2.3.ebuild:      hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"
dbus-1.2.3-r1.ebuild:   hasq test ${FEATURES} && myconf="${myconf} --enable-tests=yes"


FEATURES is a portage specific package manager configuration variable not specified in PMS and cannot reliably be used in ebuilds or eclasses.

Usually there are a number of ways to achieve the same thing though. In other cases, the usage of FEATURES in the ebuild is simply invalid.

If you need to check whether "test" is in ${FEATURES}, you can test if the USE flag "test" is set, since it will be activated in that case.

When you check for "userpriv" in ${FEATURES} you may be able to something like the following instead:

if [[ ${EUID} -eq 0 ]]; then
  rootstuff
else
  nonrootstuff
fi

Thanks
Comment 1 Didier Barvaux 2010-03-27 17:59:01 UTC
Ebuilds >=sys-apps/dbus-1.2.24 use the test useflag instead of the FEATURES variable. None of these ebuilds are stable yet, but the bug can probably be closed because the problem is fixed in new ebuilds.
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2010-03-28 05:58:37 UTC
None of the versions you mentioned in the original bug report are actually supported or maintained by Gentoo. They are merely in there to not break arches that can't get their acts together. They have security issues and therefore will not receive any action but removal. I'd urge you to hurry those arches along.
Comment 3 Didier Barvaux 2010-03-28 08:42:16 UTC
(In reply to comment #2)
> None of the versions you mentioned in the original bug report are actually
> supported or maintained by Gentoo. They are merely in there to not break arches
> that can't get their acts together. They have security issues and therefore
> will not receive any action but removal. I'd urge you to hurry those arches
> along.
> 

Do you refer to bug 297031 that requested stable for sys-apps/dbus-1.2.20 three monthes ago ?

Didier
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-09 23:09:01 UTC
1.2.3 has been dropped. Thanks for reporting.