Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 27353 - Various syntactical repoman enhancements
Summary: Various syntactical repoman enhancements
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-26 05:26 UTC by Douglas Russell (RETIRED)
Modified: 2011-10-30 22:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
repoman enhancements, based on portage-2.0.49-r1 (repoman.diff,5.06 KB, patch)
2003-08-26 05:33 UTC, Douglas Russell (RETIRED)
Details | Diff
repoman enhancements, based on portage-2.0.49-r1 (repoman.diff,5.02 KB, patch)
2003-08-26 06:20 UTC, Douglas Russell (RETIRED)
Details | Diff
RepoMan enhancements. Based on portage-2.0.49-r1. Patch on clean repoman (repoman.onclean.syn.diff,5.02 KB, patch)
2003-08-29 04:24 UTC, Douglas Russell (RETIRED)
Details | Diff
RepoMan enhancements. Based on portage-2.0.49-r1. Patch on rem patched repoman (repoman.onrem.syn.diff,5.28 KB, patch)
2003-08-29 04:26 UTC, Douglas Russell (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Russell (RETIRED) gentoo-dev 2003-08-26 05:26:51 UTC
Syntax checking for ebuilds in repoman added:
Trailing whitespace
Leading spaces
line continuation errors (\)

Header checking in repoman added:
Check line 1 for: "# Copyright 1999-XXXX Gentoo Technologies, Inc." where XXXX
is dynamic depending upon the current system time. This check allows other text
to follow the Inc. for joint copyright.
Check line 2 for: "# Distributed under the terms of the GNU General Public
License v2" exactly

Metadata checking in repoman added:
Reports missing metadata for packages

Reproducible: Always
Steps to Reproduce:
N/A
Comment 1 Douglas Russell (RETIRED) gentoo-dev 2003-08-26 05:33:18 UTC
Created attachment 16633 [details, diff]
repoman enhancements, based on portage-2.0.49-r1
Comment 2 Douglas Russell (RETIRED) gentoo-dev 2003-08-26 06:20:02 UTC
Created attachment 16635 [details, diff]
repoman enhancements, based on portage-2.0.49-r1

Slightly improved performance wise by combining 2 regexp into 1.
Comment 3 Douglas Russell (RETIRED) gentoo-dev 2003-08-26 06:24:37 UTC
Second patch also fixes minor bug
Comment 4 Douglas Russell (RETIRED) gentoo-dev 2003-08-29 04:24:38 UTC
Created attachment 16749 [details, diff]
RepoMan enhancements. Based on portage-2.0.49-r1. Patch on clean repoman

This patch patches the clean version of repoman. I.e. unpatched
Comment 5 Douglas Russell (RETIRED) gentoo-dev 2003-08-29 04:26:20 UTC
Created attachment 16750 [details, diff]
RepoMan enhancements. Based on portage-2.0.49-r1. Patch on rem patched repoman

This patches repoman after it has been patched with the (clean) rem patch:
http://bugs.gentoo.org/show_bug.cgi?id=27473
Comment 6 Douglas Russell (RETIRED) gentoo-dev 2003-08-29 04:36:43 UTC
The reason for the 2 new patches is because the patches for my 2 seperate enhancements no longer work together without manual tampering. I've worked around this with a patch for adding the syntax and metadata enhancement patch on a clean repoman and one for adding the syntax and metadata enhancement patch to a repoman already patched with the repoman cache enhancement patch (http://bugs.gentoo.org/show_bug.cgi?id=27473).

Puggy
Comment 7 Nicholas Jones (RETIRED) gentoo-dev 2003-09-02 02:43:17 UTC
syntax checks in 49-r3