Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 269742 - sys-apps/texinfo should support .xz
Summary: sys-apps/texinfo should support .xz
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-13 19:55 UTC by Martin Väth
Modified: 2015-10-18 06:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against texinfo-4.13 to support xz compression format (texinfo-4.13-xz.patch,2.21 KB, patch)
2009-05-13 19:56 UTC, Martin Väth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2009-05-13 19:55:20 UTC
The new compression format .xz which is the successor of .lzma is not yet
supported by texinfo, especially not by install-info.
This is a problem, because it means that portage will generate inappropriate
info/dir files when PORTAGE_COMPRESS="xz" is used.
The attached patch solves this problem.
Comment 1 Martin Väth 2009-05-13 19:56:26 UTC
Created attachment 191196 [details, diff]
Patch against texinfo-4.13 to support xz compression format
Comment 2 Sebastian Pipping gentoo-dev 2009-09-23 14:57:35 UTC
Martin, have you proposed this patch upstream?  What do they say?
Comment 3 Martin Väth 2009-09-24 07:08:18 UTC
> Martin, have you proposed this patch upstream?

No, I have bad experience reporting to GNU.
Comment 4 Sebastian Pipping gentoo-dev 2009-09-24 16:24:53 UTC
(In reply to comment #3)
> No, I have bad experience reporting to GNU.

Are you aware what consequences applying feature-patches downstream comes with?
Maybe give them another chance?
Comment 5 Martin Väth 2009-09-25 17:25:57 UTC
> Are you aware what consequences applying feature-patches downstream
> comes with?

Yes, unfortunately, I maintain several local patches (usually for GNU)
which are not included upstream.
I do not mind if somebody else reports it, but I will not do it:
I will of course not claim a copyright for such a tiny straightforward
patch, but I am not willing to sign a huge contract whose full consequences
are hard to estimate because of this.
Comment 6 Sebastian Pipping gentoo-dev 2009-09-27 03:25:25 UTC
If we start including feature patches down at distro level we have to port that patch over for each bump we do. That slows bumps down and is error prone. I myself wanted to have pcmanfm patches included downstream back then. Now I see it's good that it wasn't included.

I propose that you maintain ebuilds including your patches in an overlay.
We can include your overlay in the list of registered overlays (layman-global.txt) if you want.  If you agree with me please close this bug.  Otherwise please propose an alternative to applying the patch from the ebuild.
Comment 7 Martin Väth 2009-09-27 10:26:22 UTC
It is of course up to you to decide whether or not you want to include
a patch. However, I suggest to leave the bug open anyway so that people
running into the same problem will find it more easily: Rejecting to fix
a problem is ok but does not solve it.

> I propose that you maintain ebuilds including your patches in an overlay.

Thanks for the offer, but I do not have the means (i.e. accessible systems)
to provide an overlay which people can access. If a new release comes out
which requires a different patch (I suppose this will not be very often)
I will perhaps attach it to this bug (if I find the time to write it).
Comment 8 Sebastian Pipping gentoo-dev 2009-09-27 22:12:09 UTC
(In reply to comment #7)
> It is of course up to you to decide whether or not you want to include
> a patch. However, I suggest to leave the bug open anyway so that people
> running into the same problem will find it more easily: Rejecting to fix
> a problem is ok but does not solve it.

Agreed.


> > I propose that you maintain ebuilds including your patches in an overlay.
> 
> Thanks for the offer, but I do not have the means (i.e. accessible systems)
> to provide an overlay which people can access.

If you know the basics of Git that's easy.  There are several places you can get your repo hosted on.  More on that via private mail if you're interested, I would say.


> If a new release comes out
> which requires a different patch (I suppose this will not be very often)
> I will perhaps attach it to this bug (if I find the time to write it).

Sure.  Or link to your new overlay :-)
Comment 9 Tom Prince 2009-12-26 19:16:19 UTC
Upstreeam has a patch to add xz support in CVS.

http://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=bfae00d02b5fb3a2ce34c09d2dbf0ca2f96b154f
Comment 10 Tom Prince 2010-06-12 02:14:04 UTC
Apparently the url I posted earlier isn't working.

http://git.savannah.gnu.org/gitweb/?p=texinfo.git;a=commit;h=bfae00d02b5fb3a2ce34c09d2dbf0ca2f96b154f
Comment 11 SpanKY gentoo-dev 2011-02-10 03:38:59 UTC
added upstream patch (with crap fixed/cleaned up) to 4.13-r1