Bug 267926 – sys-apps/hal-0.5.12_rc1 install fails with newer sys-apps/coreutils and sys-devel/automake-1.10b

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description SpanKY 2009-04-29 22:48:14 UTC]

/usr/bin/install -c -m 644 10-dockstation.fdi 10-input-policy.fdi 10-dockstation.fdi 10-laptop-panel-mgmt-policy.fdi 10-power-mgmt-policy.fdi 10-rfkill-switch.fdi 10-tabletPCs.fdi 10-x11-input.fdi 15-storage-luks.fdi 20-storage-methods.fdi 30-wol.fdi 99-storage-policy-fixed-drives.fdi 10-keymap.fdi 10-macbookpro-utils.fdi 10-macbook-backlight.fdi 10-imac-backlight.fdi 10-cpufreq.fdi 10-usbcsr-mice.fdi '/var/tmp/portage/sys-apps/hal-0.5.12_rc1/image//usr/share/hal/fdi/policy/10osvendor'

/usr/bin/install: will not overwrite just-created `/var/tmp/portage/sys-apps/hal-0.5.12_rc1/image//usr/share/hal/fdi/policy/10osvendor/10-dockstation.fdi' with `10-dockstation.fdi'
make[4]: *** [install-dist_fdiDATA] Error 1

this is because newer coreutils `install` flags the file duplication as an error

$ touch foo
$ install foo foo /tmp/
install: will not overwrite just-created `/tmp/foo' with `foo'

[Comment 1 Maksim 'max_posedon' Melnikau 2009-05-10 14:06:38 UTC]

coreutils-7.4 + hal-0.5.12_rc1-r3 works for me

[Comment 2 SpanKY 2009-05-11 16:32:55 UTC]

not if you use autoconf-2.63b/automake-1.10b

[Comment 3 Daniel Gryniewicz (RETIRED) 2009-05-11 20:55:11 UTC]

autoconf-2.63b is masked (presumably for this reason?) and I have automake-1.10.2, which works fine.

That's a standard Makefile.am using a dist_foo_DATA target.  What should be done to fix it?

[Comment 4 SpanKY 2009-05-11 21:13:43 UTC]

no, the new automake/autoconf versions are not masked for any known bug.  they're test releases.  this is a bug in hal like i stated originally: you shouldnt be listing the same file multiple times in the data variable.  automake/coreutils are doing only what the hal build system told it to (well actually, some Gentoo step is patching/inserting the duplicated file because the vanilla source tree is OK).

[Comment 5 Jorge Manuel B. S. Vicetto (RETIRED) 2009-05-12 02:59:56 UTC]

From /var/tmp/portage/sys-apps/hal-0.5.12_rc1/work/hal-0.5.12rc1/fdi/policy/10osvendor/Makefile.am :
dist_fdi_DATA =                         \ *
        10-dockstation.fdi              \
        10-input-policy.fdi             \ *
        10-dockstation.fdi              \
        10-laptop-panel-mgmt-policy.fdi \

From extracted hal-0.5.12rc1.tar.bz2 :
dist_fdi_DATA =                         \
        10-input-policy.fdi             \
        10-dockstation.fdi              \
        10-laptop-panel-mgmt-policy.fdi \

So it seems hal-0.5.12_rc1-patches/0004-policy-for-automount-prevention-on-system-disk.patch is to blame:
diff -uNr hal-0.5.12rc1.ORIG/fdi/policy/10osvendor/Makefile.am hal-0.5.12rc1/fdi/policy/10osvendor/Makefile.am
--- hal-0.5.12rc1.ORIG/fdi/policy/10osvendor/Makefile.am        2009-03-08 21:03:32.000000000 +0000
+++ hal-0.5.12rc1/fdi/policy/10osvendor/Makefile.am     2009-03-08 21:03:55.000000000 +0000
@@ -2,6 +2,7 @@
 fdidir = $(datadir)/hal/fdi/policy/10osvendor

 dist_fdi_DATA =                        \
+       10-dockstation.fdi              \
        10-input-policy.fdi             \
        10-dockstation.fdi              \

[Comment 6 Jorge Manuel B. S. Vicetto (RETIRED) 2009-05-12 03:13:05 UTC]

Sorry, but the * in the above comment aren't in the correct lines. They were meant to highlight the double entries for 10-dockstation.fdi.
The hal-0.5.12_rc1-patches/0004-policy-for-automount-prevention-on-system-disk.patch file comes from http://dev.gentoo.org/~chainsaw/files/hal-0.5.12rc1-gentoo-patches-1.tar.bz2

[Comment 7 Daniel Gryniewicz (RETIRED) 2009-05-13 20:54:35 UTC]

Good catch.  Fixed in 0.5.12_rc1-r4.