Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266801 - media-video/gnome-mplayer-0.9.5: its nautilus extension breaks translations
Summary: media-video/gnome-mplayer-0.9.5: its nautilus extension breaks translations
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-19 19:06 UTC by Pacho Ramos
Modified: 2009-06-07 09:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-mplayer-0.9.5-nautilus-translation.patch (gnome-mplayer-0.9.5-nautilus-translation.patch,7.97 KB, patch)
2009-05-31 14:47 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2009-04-19 19:06:47 UTC
Seems that after gnome-mplayer installs:
-rw-r--r-- 1 root root 26232 abr 18 20:31 libgnome-mplayer-properties-page.a
-rwxr-xr-x 1 root root   987 abr 18 20:31 libgnome-mplayer-properties-page.la
lrwxrwxrwx 1 root root    41 abr 18 20:31 libgnome-mplayer-properties-page.so -> libgnome-mplayer-properties-page.so.0.0.0
lrwxrwxrwx 1 root root    41 abr 18 20:31 libgnome-mplayer-properties-page.so.0 -> libgnome-mplayer-properties-page.so.0.0.0
-rwxr-xr-x 1 root root 23376 abr 18 20:31 libgnome-mplayer-properties-page.so.0.0.0

nautilus is semitranslated, words like "Abrir con..." are shown in english ("Open with").

This looks very similar to bug 256406

Reproducible: Always
Comment 1 Ben de Groot (RETIRED) gentoo-dev 2009-04-20 22:22:34 UTC
CCing gnome herd: you guys have some feedback on this?
I just bumped this for the people in bug 232036, am not using gnome or nautilus myself.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-20 22:44:17 UTC
The brasero case was due to improper GETTEXT_DOMAIN iirc
Comment 3 Kevin DeKorte 2009-04-21 00:35:50 UTC
This is fixed in gnome-mplayer SVN
Comment 4 Kevin DeKorte 2009-04-21 00:37:32 UTC
http://code.google.com/p/gnome-mplayer/source/detail?r=1244

Is the fix
Comment 5 Balazs Nemeth 2009-04-25 08:06:46 UTC
I have had the same issue. I disabled the nautilus use flag, and the nautilus' translation is got back to normal.
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2009-05-29 21:34:34 UTC
(In reply to comment #4)
> http://code.google.com/p/gnome-mplayer/source/detail?r=1244
> 
> Is the fix
> 
Please provide a unified diff that applies against the release. Then we can fix it in portage. Thanks!
Comment 7 Steve Dibb (RETIRED) gentoo-dev 2009-05-29 21:47:40 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > http://code.google.com/p/gnome-mplayer/source/detail?r=1244
> > 
> > Is the fix
> > 
> Please provide a unified diff that applies against the release. Then we can fix
> it in portage. Thanks!
> 

IOW, why doesnt google code let you export a diff to txt.  Rawr.

Applied in -r1, thx guys
Comment 8 Balazs Nemeth 2009-05-31 08:23:23 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > http://code.google.com/p/gnome-mplayer/source/detail?r=1244
> > > 
> > > Is the fix
> > > 
> > Please provide a unified diff that applies against the release. Then we can fix
> > it in portage. Thanks!
> > 
> 
> IOW, why doesnt google code let you export a diff to txt.  Rawr.
> 
> Applied in -r1, thx guys
> 

Not so good. I emerged -r1 and nautilus is still semi translated.
Disabling nautilus use flag solved it.
Comment 9 Pacho Ramos gentoo-dev 2009-05-31 14:40:14 UTC
Same here :-(
Comment 10 Pacho Ramos gentoo-dev 2009-05-31 14:47:57 UTC
Created attachment 193063 [details, diff]
gnome-mplayer-0.9.5-nautilus-translation.patch

This is the patch used in rpmfusion repository for fedora. I cannot test it now, but I would welcome if anybody could test before I am able to. Thanks
Comment 11 Pacho Ramos gentoo-dev 2009-05-31 14:51:43 UTC
I think that the problem with corrently submitted patch is that it's missing:
 #ifdef ENABLE_NLS
     bindtextdomain(GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR);
     bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8");
-    textdomain(GETTEXT_PACKAGE);
+	// specify the domain in the translation calls so
+	// we don't mess up the translation of the other tabs
+	// textdomain(GETTEXT_PACKAGE);

that was comitted on the next upstream revision
Comment 12 Ben de Groot (RETIRED) gentoo-dev 2009-06-01 00:40:52 UTC
The current patch does comment out that line, so I don't think that is the issue. So if the current patch doesn't work, I could just disable the nautilus flag until the Gnome team has an opportunity to come up with a proper fix. I don't want this to prevent stabling this package any longer.
Comment 13 Ben de Groot (RETIRED) gentoo-dev 2009-06-01 01:53:42 UTC
Using commit message:
------------------------------------------------------------------------------
Drop nautilus useflag, see bug 266801. Don't enable gnome by default, let
profile or user take care of that. Leave -r1 for testing with nautilus,
while proceeding with -r2 as stable candidate.
Comment 14 Pacho Ramos gentoo-dev 2009-06-01 06:35:33 UTC
(In reply to comment #12)
> The current patch does comment out that line, so I don't think that is the
> issue. So if the current patch doesn't work, I could just disable the nautilus
> flag until the Gnome team has an opportunity to come up with a proper fix. I
> don't want this to prevent stabling this package any longer.
> 

Seems that no patch is being applied at all, are you sure adding "PATCHES=( "${FILESDIR}"/${P}-gettext.patch )" is enough?

I get
# emerge -1 =media-video/gnome-mplayer-0.9.5-r1
Calculating dependencies... done!

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) media-video/gnome-mplayer-0.9.5-r1
 * gnome-mplayer-0.9.5.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                                         [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                  [ ok ]
 * checking auxfile checksums ;-) ...                                                                                                                 [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                [ ok ]
>>> Unpacking source...
>>> Unpacking gnome-mplayer-0.9.5.tar.gz to /var/tmp/portage/media-video/gnome-mplayer-0.9.5-r1/work
>>> Source unpacked in /var/tmp/portage/media-video/gnome-mplayer-0.9.5-r1/work
>>> Preparing source in /var/tmp/portage/media-video/gnome-mplayer-0.9.5-r1/work/gnome-mplayer-0.9.5 ...
 * Fixing OMF Makefiles ...                                                                                                                            [ ok ]
 * Running elibtoolize in: gnome-mplayer-0.9.5
 *   Applying install-sh-1.5.4.patch ...
 *   Applying portage-1.5.10.patch ...
 *   Applying sed-1.5.6.patch ...
 *   Applying as-needed-1.5.patch ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-video/gnome-mplayer-0.9.5-r1/work/gnome-mplayer-0.9.5 ...
 * econf: updating gnome-mplayer-0.9.5/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating gnome-mplayer-0.9.5/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --with-gio --with-alsa --with-gconf --enable-schemas-install --enable-nautilus --without-libgpod --with-libnotify --with-libmusicbrainz3
checking for a BSD-compatible install... /usr/bin/install -c
Comment 15 Ben de Groot (RETIRED) gentoo-dev 2009-06-01 19:28:32 UTC
OK, I have now added the patch from Pacho Ramos, as the other one didn't actually apply, and edited the ebuild to make sure the patch gets applied. Can someone test after next sync if this works with nautilus?
Comment 16 Pacho Ramos gentoo-dev 2009-06-03 07:45:22 UTC
Seems to work ok now for me
Comment 17 Balazs Nemeth 2009-06-05 18:52:00 UTC
0.9.5-r1 works fine with or without the nautilus USE flag.
0.9.5-r2 makes nautilus semi translated as described here before.
Comment 18 Pacho Ramos gentoo-dev 2009-06-07 09:03:15 UTC
(In reply to comment #17)
> 0.9.5-r1 works fine with or without the nautilus USE flag.
> 0.9.5-r2 makes nautilus semi translated as described here before.
> 

Yes, you are true, maybe this is caused because -r2 ebuild is not disabling nautilus extension build and its build seems to be default option.

I think that -r2 should be removed and -r1 should go for stabilization now that it's fixed
Comment 19 Samuli Suominen (RETIRED) gentoo-dev 2009-06-07 09:21:07 UTC
- Added latest gnome-mplayer-0.9.6 in tree.
- Added --disable-nautilus to 0.9.5-r2