262881 – net-nntp/hellanzb shows deprecation warnings with python-2.6

Bug 262881 - net-nntp/hellanzb shows deprecation warnings with python-2.6

Summary: net-nntp/hellanzb shows deprecation warnings with python-2.6

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Alexis Ballier

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	python-2.6
	Show dependency tree

Reported:	2009-03-18 06:57 UTC by Ben de Groot (RETIRED)
Modified:	2010-04-23 13:36 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Fix python-2.6 DeprecationWarning (hellanzb-0.13-python_26_fixes.diff,2.58 KB, patch) 2009-05-05 15:34 UTC, rinus	Details \| Diff
New ebuild (hellanzb-0.13-r7.ebuild,1.73 KB, text/plain) 2009-05-05 15:35 UTC, rinus	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben de Groot (RETIRED) gentoo-dev

2009-03-18 06:57:56 UTC

When using xmlrpc to communicate with the hellanzb daemon, these deprecation warnings are always shown:

/usr/lib64/python2.6/site-packages/twisted/internet/_sslverify.py:5: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import itertools, md5
/usr/lib64/python2.6/site-packages/twisted/python/filepath.py:12: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  import sha
/usr/lib64/python2.6/site-packages/Hellanzb/Util.py:33: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  self.message = message

Installed hellanzb version is 0.13-r7
Installed python version is 2.6.1

Comment 1 Martin Berkemeier 2009-04-10 17:54:15 UTC

here too. with python-2.6.1-r1 and hellanzb-0.13-r7

Comment 2 rinus 2009-05-05 15:34:30 UTC

Created attachment 190418 [details, diff]
Fix python-2.6 DeprecationWarning

I found a ticket at the hellanzb project: http://www.hellanzb.com/trac/hellanzb/ticket/419
I took the patch from there and made it work for gentoo (deleted 2 hunks because the files are not there).
There is still a problem with the dev-python/twisted-8.2.0 package.
I will create a new bug for that.
New ebuild with added patch line will follow.

Comment 3 rinus 2009-05-05 15:35:40 UTC

Created attachment 190420 [details]
New ebuild

Comment 4 rinus 2009-05-05 17:10:39 UTC

See bug 268737 for the dev-python/twisted-8.2.0 part.

Comment 5 Alexis Ballier gentoo-dev

2009-08-05 09:47:22 UTC

Why do you do "try import hashlib except importerror" ? At least python2.5 has hashlib here.
This would be fine if the patch didn't change later the call from md5.new() to md5() which will probably fail if hashlib isn't there.

Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev

2009-08-05 16:49:23 UTC

(In reply to comment #5)
> Why do you do "try import hashlib except importerror" ? At least python2.5
> has hashlib here.

He probably wants to support Python 2.4...

> This would be fine if the patch didn't change later the call from md5.new()
> to md5() which will probably fail if hashlib isn't there.

It won't fail.

Comment 7 Alexis Ballier gentoo-dev

2010-04-23 13:36:47 UTC

applied, thanks