Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 260281 - dev-python/editobj should use USE flag dependencies from EAPI-2
Summary: dev-python/editobj should use USE flag dependencies from EAPI-2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 239930
  Show dependency tree
 
Reported: 2009-02-25 18:03 UTC by Pavel Bazika
Modified: 2009-03-01 20:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch adding python tk USE flag dependency (editobj.usedep.patch,6.41 KB, patch)
2009-02-27 23:25 UTC, Pavel Bazika
Details | Diff
Patch adding python tk USE flag dependency (editobj.usedep.patch,1.10 KB, patch)
2009-03-01 14:40 UTC, Pavel Bazika
Details | Diff
Patch adding python tk USE flag dependency (editobj.usedep.patch,3.08 KB, patch)
2009-03-01 15:19 UTC, Pavel Bazika
Details | Diff
Patch adding python tk USE flag dependency (editobj.usedep.patch,1.99 KB, patch)
2009-03-01 15:22 UTC, Pavel Bazika
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Bazika 2009-02-25 18:03:37 UTC
When emerging dev-python/editobj, python must be compiled with "tk" USE flag. If it's not, then editobj ebuild failed with error message.
In recent portage versions is possible to define USE flag dependencies. editobj ebuild should use this interface.

Reproducible: Always

Steps to Reproduce:
1. Emerge python without "tk" USE flag
2. Try to merge editobj - fails


Actual Results:  
Merge process ends with error - recompile python with "tk" USE flag

Expected Results:  
USE flag dependency error should show when "calculating dependencies"
Comment 1 Pavel Bazika 2009-02-25 18:06:03 UTC
Tested on dev-python/editobj-0.5.6

My emerge info:
Portage 2.1.6.7 (default/linux/x86/2008.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.28-gentoo-r2 i686)
=================================================================
System uname: Linux-2.6.28-gentoo-r2-i686-Intel-R-_Core-TM-2_Duo_CPU_P8400_@_2.26GHz-with-glibc2.0
Timestamp of tree: Wed, 25 Feb 2009 17:15:03 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.5.2-r7
dev-util/cmake:      2.6.2-r1
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.63
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O3 -fomit-frame-pointer -march=prescott -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/4.2/env /usr/kde/4.2/share/config /usr/kde/4.2/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O3 -fomit-frame-pointer -march=prescott -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://gentoo.mirror.web4u.cz http://gentoo.supp.name rsync://ftp.fi.muni.cz/pub/linux/gentoo"
LANG="cs_CZ.utf8"
LDFLAGS="-Wl,-O1"
LINGUAS="cs"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="16bit X a52 aac acl acpi alsa amarok amazon aotuv apache2 apm audacious automount bash-completion berkdb bidi binary-drivers bindist bittorrent branding bzip2 cdaudio cdda cdinstall cdparanoia cdr cdrom chm cjk cli color-console colordiff cpudetection cracklib crypt cscope css cups cupsddk cvs cvsgraph dbus dga disk-partition divx djvu dnotify dri dv dvd dvdr emoticon enca encode eolconv epson exif fastbuild fat fbcon fbcondecor fbsplash ffmpeg fftw firefox flac fontforge fortran ftp fuse gd gdbm geoip gif gimp git gkrellm glibc-omitfp gmedia gpg gpm grub gs gutenprint hal hou hpn htmlhandbook ia32 icon icons iconv icq icu id3 id3tag ide ieee1394 imagemagick imlib inotify ipv6 isdnlog jack java javascript jikes jpeg jpeg2k kde kdeprefix kdrive kino kmid lame langpacks laptop levels libnotify libsamplerate linuxthreads-tls lirc lircsettings live livebuffer lm_sensors matroska matrox mdnsresponder-compat memlimit midi mime mixer mjpeg mmx mmxext mng module mono mouse mozdevelop mozdom mozilla moznoirc mp2 mp3 mp4 mp4live mpeg mpeg2 mplayer mudflap multislot musepack music musicbrainz mysql ncurses nemesi net network nforce2 nls nocd nowin nowlistening nptl nptlonly nsplugin ntfs nuv office ogg opengl openmp openssh pam pascal pcre pdf perl php plasma pmount pmu png pop posix ppds pppd print privacy ps python qt3 qt3support qt4 quicktime radio rar raw rdesktop readline realmedia reflection reiserfs replaygain replytolist roe rss rtc rtf samba sametime scanner scenarios sdl sdl-image sdlaudio semantic-desktop sensord session skins sms sou sound sounds spell spl sqlite sqlite3 srt sse sse2 ssl ssse3 stroke subtitles subversion suid svg svg-experimental svgz sysfs syslog systray sysvipc taglib tagwriting tcpd teletext texteffect textures tga theora threads threadsafe tiff timidity transcode trayicon truetype tse3 tta twolame ui unicode urlpicpreview usb userlocales v4l v4l2 vdr vhosts video videos vidix vim-with-x visualization vnc volctrl vorbis vorbis-psy wav wavpack win32codecs wma wmf wmp x264 x86 xatrix xcomposite xext xine xinerama xml xmp xorg xpm xrandr xulrunner xv xvid xvmc zip zlib zvbi" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" CAMERAS="fuji" ELIBC="glibc" INPUT_DEVICES="keyboard mouse joystick evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="cs" LIRC_DEVICES="devinput" NETBEANS_MODULES="nb harness ide java websvccommon" USERLAND="GNU" VIDEO_CARDS="fglrx radeon radeonhd"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-02-27 12:31:49 UTC
Pavel, you could save our devs some work by providing an ebuild patch which incorporates the changes you suggested...

Reassigning to python herd.
Comment 3 Pavel Bazika 2009-02-27 23:25:00 UTC
Created attachment 183426 [details, diff]
Patch adding python tk USE flag dependency

Sorry, I prepared the patch and then was suddenly disconnected. Here it is for EditObj versions 0.5.3, 0.5.6 and 0.5.7.
There is still a problem with eclass which is used by this ebuild - it's needed to remove old error report.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-01 14:19:25 UTC
Your attached file is no diff.
You can create a diff like that:

diff -u original.ebuild your_patched.ebuild > diff
Comment 5 Pavel Bazika 2009-03-01 14:40:09 UTC
Created attachment 183557 [details, diff]
Patch adding python tk USE flag dependency
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-01 14:56:30 UTC
USE flag dependencies were introduced with EAPI-2 so you have to mark an ebuild as such when you want to use this feature.
Just put a line

  EAPI="2"

as first line after the ebuild's header. Have a look at the x11-themes/qtcurve-qt4-0.61.2.ebuild to see what I mean.
Comment 7 Pavel Bazika 2009-03-01 15:19:02 UTC
Created attachment 183560 [details, diff]
Patch adding python tk USE flag dependency

EAPI 2 declaration added. Thanks Lars.
Comment 8 Pavel Bazika 2009-03-01 15:22:01 UTC
Created attachment 183561 [details, diff]
Patch adding python tk USE flag dependency

Here is correct EAPI 2 patch.
Comment 9 Jesus Rivero (RETIRED) gentoo-dev 2009-03-01 20:00:49 UTC
Hello, 

    revbump in tree now, thanks to Pavel for the patches.. keep 'em coming ;)

    Best regards,