Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250853 - app-vim/vim-spell-{cs,da,fr,nl,pl} failing doins does not stop ebuild
Summary: app-vim/vim-spell-{cs,da,fr,nl,pl} failing doins does not stop ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-13 17:58 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-07-07 18:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to solve the problem. (sug.patch,333 bytes, patch)
2009-04-06 02:00 UTC, Robson Roberto Souza Peixoto
Details | Diff
The patch sug.patch was tested with that ebuild. (vim-spell-pt-br-20090330.ebuild,694 bytes, text/plain)
2009-04-06 02:01 UTC, Robson Roberto Souza Peixoto
Details
Another patch to solve the problem (sug2.patch,457 bytes, patch)
2009-04-06 02:31 UTC, Robson Roberto Souza Peixoto
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-13 17:58:03 UTC
app-vim/vim-spell-cs-20061021:20081212-201354.log:!!! doins: *.sug does not exist
app-vim/vim-spell-da-20060116:20081212-201420.log:!!! doins: *.sug does not exist
app-vim/vim-spell-fr-20060121:20081212-201635.log:!!! doins: *.sug does not exist
app-vim/vim-spell-nl-20051007:20081212-201701.log:!!! doins: *.sug does not exist
app-vim/vim-spell-pl-20060218:20081212-201726.log:!!! doins: *.sug does not exist

Not sure why this happens, not sure if it should abort, but still worth checking out.
Comment 1 Robson Roberto Souza Peixoto 2009-04-06 01:10:06 UTC
I think is because some think like this:

robinho@robinho ~/tmp $ pwd
/home/robinho/tmp

robinho@robinho ~/tmp $ ls
hi.oi  this.tk

robinho@robinho ~/tmp $ for i in *.ls *.tk; do
> echo $i
> done
*.ls
this.tk


I don't have any file *.ls, but the for put '*.ls' on i.

In /usr/portage/eclass/vim-spell.eclass has it:
    had_spell_file=
    for f in *.spl *.sug ; do
        doins "${f}"
        had_spell_file="yes"
    done

I think only necessary put it:
    had_spell_file=
    for f in *.spl *.sug ; do
        if [ -f "${f}" ]; then
            doins "${f}"
            had_spell_file="yes"
        fi
    done


Good luck !
Comment 2 Robson Roberto Souza Peixoto 2009-04-06 02:00:54 UTC
Created attachment 187430 [details, diff]
Patch to solve the problem.
Comment 3 Robson Roberto Souza Peixoto 2009-04-06 02:01:44 UTC
Created attachment 187432 [details]
The patch sug.patch was tested with that ebuild.
Comment 4 Robson Roberto Souza Peixoto 2009-04-06 02:31:38 UTC
Created attachment 187434 [details, diff]
Another patch to solve the problem

I think that patch is better because .sug is optimal. If .sug exist not necessary have a dictionary.

Thanks.
Sorry my English.
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-07-07 18:54:51 UTC
Fixed.