Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 249780 - app-arch/p7zip version bump to 4.65 including new GUI
Summary: app-arch/p7zip version bump to 4.65 including new GUI
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Radoslaw Stachowiak (RETIRED)
URL: http://sourceforge.net/projects/p7zip/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2008-12-04 10:38 UTC by Justin Lecher (RETIRED)
Modified: 2009-04-27 16:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
p7zip-4.61.ebuild.patch (p7zip-4.61.ebuild.patch,1.60 KB, text/plain)
2008-12-04 10:38 UTC, Justin Lecher (RETIRED)
Details
files/4.61-makefile.patch (4.61-makefile.patch,411 bytes, text/plain)
2008-12-04 10:39 UTC, Justin Lecher (RETIRED)
Details
/mnt/tmpfs/p7zip-4.61-r1.ebuild.diff (p7zip-4.61-r1.ebuild.diff,1.76 KB, text/plain)
2008-12-04 19:38 UTC, Justin Lecher (RETIRED)
Details
p7zip-4.58-to-4.61.ebuild.diff (p7zip-4.58-to-4.61.ebuild.diff,1.78 KB, patch)
2009-01-06 21:58 UTC, Sergey Dryabzhinsky
Details | Diff
app-arch/p7zip/p7zip-4.61.ebuild (p7zip-4.61.ebuild,3.07 KB, text/plain)
2009-02-09 22:23 UTC, Ilya Kashirin
Details
Makefile patch no longer needed, RAR decompression support (p7zip-4.65.ebuild,3.20 KB, text/plain)
2009-04-11 09:40 UTC, A.C.Heron
Details
Changed license for RAR decompressor (p7zip-4.65.ebuild,3.21 KB, text/plain)
2009-04-11 10:40 UTC, A.C.Heron
Details
Makefile patch no longer needed, RAR decompression support, unRAR license (p7zip-4.65.ebuild,3.21 KB, text/plain)
2009-04-23 17:55 UTC, A.C.Heron
Details
Makefile patch no longer needed, RAR decompression support, unRAR license (p7zip-4.65.ebuild,3.12 KB, text/plain)
2009-04-24 23:56 UTC, A.C.Heron
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2008-12-04 10:38:05 UTC
There is version bump:

Version 4.61
============
  - From Windows version of 7-zip 4.61 :
    - 7-Zip now supports LZMA compression for .ZIP archives.
    - Some bugs were fixed.

  - #2199036 : Ask for password twice when creating encrypted archive

  - 7zG added (read GUI/readme.txt)


Version 4.60 (never published)
============

  - From Windows version of 7-zip 4.60 :
    - Some bugs were fixed

  - p7zip didn't use the BCJ /BCJ2 filters for executables (:
  - makefile.linux_amd64_asm_icc added (tested with Intel Compiler 11 on Ubuntu 8.04 x64)


Version 4.59 (never published)
============

  - From Windows version of 7-zip 4.59 :
    - 7-Zip now can unpack UDF, XAR and DMG/HFS archives.
    - It's allowed to use -t switch for "list" and "extract" commands.
    - Some bugs were fixed.

  - Bug : wrong timestamp for files extracted from .zip or .rar archives




I supply a patch I propose for the bump. The only things which needs a close look, are the .desktop files supplied in the tarball. They are for kde I don't know how to handle. I f they could be used in /usr/share/applications, if they should go somewhere else... Teach me and I will include it.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2008-12-04 10:38:47 UTC
Created attachment 174218 [details]
p7zip-4.61.ebuild.patch

patch
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2008-12-04 10:39:00 UTC
Created attachment 174220 [details]
files/4.61-makefile.patch

makefile.patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-04 16:31:33 UTC
wxGTK dependencies aren't so easy on EAPI=0, you should probably want to use EAPI=2 and wxGTK[X], and it should be dependent on X USE flag I guess, unless they used wxBase for other stuff too, in which case it should probably be wxGTK[X?].
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2008-12-04 18:15:48 UTC
Of course you are right. Didn't notice the X USE on wxGTK, as I thought widgets always need X.
K, I update for that. Thanks for pointing me on that.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2008-12-04 19:38:12 UTC
Created attachment 174258 [details]
/mnt/tmpfs/p7zip-4.61-r1.ebuild.diff

EAPI="2" version as Diego suggested.

Is EAPI2 supported in portage-2.1.6?
Comment 6 Mr. B 2009-01-02 18:05:55 UTC
(In reply to comment #5)
> Created an attachment (id=174258) [edit]
> /mnt/tmpfs/p7zip-4.61-r1.ebuild.diff
> 
> EAPI="2" version as Diego suggested.
> 
> Is EAPI2 supported in portage-2.1.6?
> 

Replying in the interests of keeping this ticket alive; yes.
Comment 7 Sergey Dryabzhinsky 2009-01-06 21:28:16 UTC
Maybe the 'X' flag shoud be changed to 'wxwindows' like in other ebuilds? 
Comment 8 Sergey Dryabzhinsky 2009-01-06 21:33:03 UTC
Oh, and I think there should be no hard dep:

 RDEPEND="X? ( x11-libs/wxGTK[X] )" # EAPI=2
Comment 9 Justin Lecher (RETIRED) gentoo-dev 2009-01-06 21:38:21 UTC
(In reply to comment #8)
> Oh, and I think there should be no hard dep:
> 
>  RDEPEND="X? ( x11-libs/wxGTK[X] )" # EAPI=2
> 

Yiep, right.
Comment 10 Sergey Dryabzhinsky 2009-01-06 21:58:09 UTC
Created attachment 177604 [details, diff]
p7zip-4.58-to-4.61.ebuild.diff

Based on 4.61-r1 and latest 4.58 from portage, with EAPI=2 and USE-flag 'wxwindows'
Comment 11 Ilya Kashirin 2009-02-09 22:23:55 UTC
Created attachment 181493 [details]
app-arch/p7zip/p7zip-4.61.ebuild
Comment 12 Raúl Porcel (RETIRED) gentoo-dev 2009-02-18 17:08:13 UTC
4.65 is out
Comment 13 A.C.Heron 2009-04-11 09:40:58 UTC
Created attachment 187961 [details]
Makefile patch no longer needed, RAR decompression support

Added "rar" USE flag to enable non-free RAR decoder.
Changed sed command in src_prepare() so that it affects only compilation flags, but not creating the symlinks.
Tested with p7zip-4.65 on AMD64.
Comment 14 Justin Lecher (RETIRED) gentoo-dev 2009-04-11 09:43:25 UTC
You have to somehow adopt the license then.
Comment 15 A.C.Heron 2009-04-11 10:14:59 UTC
What do you mean "adopt the license"? 

Change the license in the ebuild? I'll do that. 

The ebuild should ask the user if he accepts the unrar license? What is the best way to do that?
Comment 16 Justin Lecher (RETIRED) gentoo-dev 2009-04-11 10:17:56 UTC
(In reply to comment #15)
> What do you mean "adopt the license"? 
> 
> Change the license in the ebuild? I'll do that. 
> 
> The ebuild should ask the user if he accepts the unrar license? What is the
> best way to do that?
> 

This is something we must think about ( and better query some devs ).
I just wanted to remind that there is only the free license in the ebuild. Perhaps it is enough to set
LICENSE="|| ( GPL-2 NONFREELICENSE )"
Comment 17 A.C.Heron 2009-04-11 10:31:12 UTC
> This is something we must think about ( and better query some devs ).

There used to be something like that in app-emulation/virtualbox-bin. It showed the license and then stopped  and waited for user to accept or decline it. But it has been removed.
Comment 18 A.C.Heron 2009-04-11 10:40:32 UTC
Created attachment 187967 [details]
Changed license for RAR decompressor

Same as before, but with LICENSE="|| ( LGPL-2.1 unRAR )"
Comment 19 Chí-Thanh Christopher Nguyễn gentoo-dev 2009-04-20 15:17:18 UTC
I think LICENSE="|| ( LGPL-2.1 unRAR )" is not correct. The resulting package is governed both by LGPL-3 and unRAR licenses and not one of them according to the user's choice.
Comment 20 A.C.Heron 2009-04-20 20:18:15 UTC
If the user sets USE="-rar", the resulting license is exactly LGPL. If the user sets USE="rar", the resulting license is LGPL with additional unrar restrictions (to put it simply: "Do not reverse engineer the compression algorithm; do not sell the decompressor without the written permission"). 

What should it be? LICENSE="|| ( LGPL-2.1 unRAR+LGPL-2.1 )" ?
Comment 21 Justin Lecher (RETIRED) gentoo-dev 2009-04-20 20:23:59 UTC
(In reply to comment #20)
> If the user sets USE="-rar", the resulting license is exactly LGPL. If the user
> sets USE="rar", the resulting license is LGPL with additional unrar
> restrictions (to put it simply: "Do not reverse engineer the compression
> algorithm; do not sell the decompressor without the written permission"). 
> 
> What should it be? LICENSE="|| ( LGPL-2.1 unRAR+LGPL-2.1 )" ?
> 

right syntax would be:

LICENSE="rar? ( LGPL-2.1 unRAR ) !rar? ( LGPL-2.1 )"
Comment 22 Chí-Thanh Christopher Nguyễn gentoo-dev 2009-04-20 20:34:13 UTC
LICENSE="LGPL-2.1 rar? ( unRAR )" would also be ok
Comment 23 A.C.Heron 2009-04-23 17:55:47 UTC
Created attachment 189254 [details]
Makefile patch no longer needed, RAR decompression support, unRAR license

Changed LICENSE to "LGPL-2.1 rar? ( unRAR )"
Comment 24 Justin Lecher (RETIRED) gentoo-dev 2009-04-23 18:13:19 UTC
If I have time the next days and the maintainer doesn't shows up or react, I will commit the changes via a proxy maintainer I found.
Comment 25 Chí-Thanh Christopher Nguyễn gentoo-dev 2009-04-24 14:36:00 UTC
There are still some possible issues with the ebuild:
in RDEPEND it should be kde-base/konqueror:3.5 rather than >=kde-base/konqueror:3.5
the next line should read DEPEND="${RDEPEND}" not RDEPENDS
Comment 26 Justin Lecher (RETIRED) gentoo-dev 2009-04-24 14:50:02 UTC
This is the latest version I use

http://gentoo.j-schmitz.net/portage/ebuilds/app-arch/p7zip/p7zip-4.65.ebuild
Comment 27 A.C.Heron 2009-04-24 23:56:13 UTC
Created attachment 189361 [details]
Makefile patch no longer needed, RAR decompression support, unRAR license

> in RDEPEND it should be kde-base/konqueror:3.5
Corrected.
By the way, it looks like it should work in KDE 4. Maybe that should be reflected in the dependencies?

> the next line should read DEPEND="${RDEPEND}" 
Corrected.
Comment 28 Patrick Lauer gentoo-dev 2009-04-26 20:59:31 UTC
+*p7zip-4.65 (26 Apr 2009)
+
+  26 Apr 2009; Patrick Lauer <patrick@gentoo.org>
+  +files/4.65-hardlink.patch, +files/4.65-makefile.patch, metadata.xml,
+  +p7zip-4.65.ebuild:
+  Bump to 4.65, closes #249780. Based on the ebuild by jlec, incorporating
+  changes from Flameeyes, Sergey Dryabzhinsky, Ilya Kashirin, A.C.Heron and
+  Chi-Thanh Christopher Nguyen.

Hope I didn't forget anyone. Please test it a bit to see if everything works as expected :)
Comment 29 Tomáš Chvátal (RETIRED) gentoo-dev 2009-04-27 16:03:49 UTC
Ok just slightly adjusted build system for kde4 compilance, it needs more fixing tho. Installing translations and html stuff into lib is not peachy...