Because in media-video/ffmpeg-0.4.9_p20081014 the deprecated function "avcodec_decode_audio" was removed the sources of picard have to be adapted to use "avcodec_decode_audio2". I hope, that the changes I made are right (it is working for me). I reported the problem upstream. http://forums.musicbrainz.org/viewtopic.php?id=1369 Reproducible: Always Steps to Reproduce:
Created attachment 171160 [details] media-sound/picard-0.10-r2.ebuild The updated ebuild that use the patch (if a special ffmpeg version is installed)
Created attachment 171162 [details, diff] picard-0.10.0_ffmpeg_decode_audio2_support.patch The patch to use not the deprecated function.
Thanks for submitting your patch to support newer ffmpeg, assigning to maintainers.
Created attachment 173733 [details, diff] picard-0.10-avcodev-version.patch Use the pre processor so that we don't have to patch conditionally
avcodec_decode_audio was such: int avcodec_decode_audio(AVCodecContext *avctx, int16_t *samples, int *frame_size_ptr, const uint8_t *buf, int buf_size){ *frame_size_ptr= AVCODEC_MAX_AUDIO_FRAME_SIZE; return avcodec_decode_audio2(avctx, samples, frame_size_ptr, buf, buf_size); } so in the patch the equivalent would be to set output_size to AVCODEC_MAX_AUDIO_FRAME_SIZE before calling avcodec_decode_audio2; moreover you can do this unconditionally as this function has been there and like that for years.
@Lars Strojny I believe that is better, too. Thanks
Patch applied (as applied upstream) in 0.10-r2. Thanks to all of you.
(In reply to comment #7) > Patch applied (as applied upstream) in 0.10-r2. > Hi, 0.10-r2 is not in the tree. It is not present in CVS either http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/picard/ But probably stabilizing 0.11 is a better idea ?
