First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 236858
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Martin Väth <vaeth@mathematik.uni-wuerzburg.de>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
crypto-loop.initd.patch Patch to make crypto-loop.initd POSIX compliant patch Martin Väth 2008-09-06 13:05 0000 1.56 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 236858 depends on: Show dependency tree
Bug 236858 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-09-06 12:57 0000 
As the summary says, file/crypto-loop.initd uses several bashisms which make
the file fail if e.g. /bin/sh is a symlink to dash.
As usual, only small syntax changes are necessary to make it POSIX compliant.
I attach a patch.

------- Comment #1 From Martin Väth 2008-09-06 13:05:23 0000 ------- 
Created an attachment (id=164719) [details]
Patch to make crypto-loop.initd POSIX compliant

The patch in addition removes the redundant call of "ls" which might have
produced a confusing error message if no /dev/loop[0-9] exists
(and a new line was inserted to deal with that case).

------- Comment #2 From Wormo 2008-09-06 17:59:50 0000 ------- 
Thanks for the cleanup patch, assigning to maintainers

------- Comment #3 From SpanKY 2008-10-26 03:16:36 0000 ------- 
changing [[ -n ${var} ]] to [ -n ${var} ] is broken

ive fixed things up and committed it, thanks

http://sources.gentoo.org/sys-apps/util-linux/files/crypto-loop.initd?r1=1.3&r2=1.4
First Last Prev Next    No search results available      Search page      Enter new bug