Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 233184 - sys-apps/hal-0.5.11-r1 should use die in src_install
Summary: sys-apps/hal-0.5.11-r1 should use die in src_install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Project Gentopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-28 18:47 UTC by Daniel Pielmeier
Modified: 2008-12-24 15:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
hal-0.5.11-r1.diff (hal-0.5.11-r1.diff,1.45 KB, patch)
2008-07-28 18:49 UTC, Daniel Pielmeier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Pielmeier gentoo-dev 2008-07-28 18:47:20 UTC
${WORKDIR}/${P}-extras has changed to ${WORKDIR}/${PN}-config-examples and the build does not die because of the missing files.

dodoc, newexe, newinitd, cp, dobin should die when files are not present. I don't know if newexe or newinitd die automatically but it is not the case for dodoc, dobin and cp.
Comment 1 Daniel Pielmeier gentoo-dev 2008-07-28 18:49:04 UTC
Created attachment 161561 [details, diff]
hal-0.5.11-r1.diff

Uses die function in src_install.
Changes ${P}-extras to ${PN}-config-examples.
Comment 2 Daniel Pielmeier gentoo-dev 2008-08-02 15:55:54 UTC
No comments on this? I mean this is a stable hal version and it does not install important files. The xorg to fdi migration script does not run also. This might cause confusion when users think the conversion was done and delete the relevant entries from xorg.conf and then getting problems with the keybord layout.
Comment 3 Daniel Pielmeier gentoo-dev 2008-08-02 16:15:42 UTC
Also the elog message about the removal of the Input sections from xorg.conf is a bit confusing as only the keyboard settings are migrated. So one could think he can safely remove all InputDevice Sections from xorg.conf including mice and other input devices.
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2008-12-24 15:38:00 UTC
I've incorporated these changes slightly differently. Thanks for the prod about this bug.