Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 232803 - app-portage/gentoolkit-0.2.4_rc5: equery check incorrectly identifies matching mtime
Summary: app-portage/gentoolkit-0.2.4_rc5: equery check incorrectly identifies matchin...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 170220
  Show dependency tree
 
Reported: 2008-07-23 23:33 UTC by Alexey Parshin
Modified: 2008-08-27 16:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for equery to fix the bug (equery_mtime.patch,551 bytes, text/plain)
2008-07-24 03:21 UTC, Alexey Parshin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Parshin 2008-07-23 23:33:36 UTC
equery check <package name> prints messages like:

!!! /usr/bin/euse has wrong mtime (is 1215730638, should be 1215730638)

where matching mtime is considered as wrong

Reproducible: Always

Steps to Reproduce:
1. equery check gentoolkit

Actual Results:  
...
!!! /usr/bin/euse has wrong mtime (is 1215730638, should be 1215730638)
...
 * 24 out of 71 files good


Expected Results:  
 * 71 out of 71 files good


Gentoolkit: 0.2.4-rc5

alexey@th $ emerge --info
Portage 2.2_rc2 (default-linux/x86/2007.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.26-rc8-zen1.0 i686)
=================================================================
System uname: Linux-2.6.26-rc8-zen1.0-i686-Genuine_Intel-R-_CPU_T2400_@_1.83GHz-with-glibc2.0
Timestamp of tree: Wed, 23 Jul 2008 20:45:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.5.2-r5
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.62-r1
sys-devel/automake:  1.4_p6, 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=prescott -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/svn/env /usr/kde/svn/share/config /usr/kde/svn/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=prescott -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks parallel-fetch preserve-libs sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.swin.edu.au/gentoo ftp://ftp.swin.edu.au/gentoo ftp://mirror.pacific.net.au/linux/Gentoo http://gentoo.arcticnetwork.ca/source/ http://gentoo.osuosl.org/"
LANG="en_AU.UTF-8"
LDFLAGS=""
LINGUAS="en ru"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/desktop-effects /usr/portage/local/layman/zen-overlay /usr/portage/local/myoverlay"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="7zip X a52 aac acl acpi alsa amd aspell bash-completion berkdb bluetooth branding bzip2 cairo cardbus cdr cli cpudetection cracklib crypt cups curl dbus divx dri dts dv dvd dvdr dvdread encode evo fam fat ffmpeg filepicker firefox fixme flac foomaticdb ftp fuse gdbm gif gimp glitz gmail gnome gpm gstreamer gtk gzip h323 hal hpn iconv ieee1394 imap ipv6 irc isdnlog jpeg jpeg2k lame libwww lm_sensors lzo mad maildir matroska midi mime mjpeg mmap mmx mmxext mng mp3 mp4 mp4live mpeg2 mplayer mudflap mysql nautilus ncurses nfs nls nntp nptl nptlonly nsplugin ntfs obex odbc ogg opengl openmp pam pango pcmcia pcre perl png postgres ppds pppd python qt3support quicktime rar readline real realmedia reflection reiserfs rpm rtc samba sasl scanner session slang smp sockets socks5 spell spl sse sse2 ssl stream subtitles subversion svg tcpd tga theora thesaurus threads threadsafe tiff transcode truetype type1 unicode usb v4l v4l2 valgrind vorbis wavpack webdav wifi win32codecs wma wmf wmp wxwindows x264 x86 xanim xcomposite xfs xine xinetd xml xorg xosd xpm xprint xulrunner xv xvid xvmc zip zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="*" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="peruser" ELIBC="glibc" INPUT_DEVICES="synaptics keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en ru" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Michael Perlov 2008-07-23 23:39:41 UTC
(In reply to comment #0)

# equery check gentoolkit
[ Checking app-portage/gentoolkit-0.2.4_rc5 ]
 * 71 out of 71 files good

# emerge --info
Portage 2.2_rc2 (default/linux/x86/2008.0, gcc-4.3.1, glibc-2.8_p20080602-r0, 2.6.25.6 i686)
=================================================================
System uname: Linux-2.6.25.6-i686-Intel-R-_Pentium-R-_4_CPU_1.80GHz-with-glibc2.0
Timestamp of tree: Wed, 23 Jul 2008 19:30:01 +0000
app-shells/bash:     3.2_p39
dev-java/java-config: 1.3.7, 2.1.6-r1
dev-lang/python:     2.4.4-r9, 2.5.2-r5
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-apps/sandbox:    1.2.18.1-r3
sys-devel/autoconf:  2.13, 2.62-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   2.2.4
virtual/os-headers:  2.6.25-r4
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium4 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks parallel-fetch preserve-libs sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirror.hamakor.org.il/pub/mirrors/gentoo/ ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://mirror.gentoo.no/"
LANG="ru_RU.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS="en ru"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/overlays/my /usr/local/overlays/layman/enlightenment"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl alsa apache2 berkdb bzip2 cli cracklib crypt dbus dri dvdr flac fortran gdbm gif gpm gtk2 hal iconv ipv6 isdnlog jpeg midi mmx mp3 mudflap ncurses nls nptl nptlonly nsplugin nvidia ogg opengl openmp pam pcre perl png pppd python readline reflection session spl sse sse2 ssl svg tcpd unicode vorbis win32codecs x86 xorg xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en ru" LIRC_DEVICES="audio audio_alsa" USERLAND="GNU" VIDEO_CARDS="nvidia none"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-07-24 02:49:27 UTC
Same here as comment #1

%% equery check gentoolkit
[ Checking app-portage/gentoolkit-0.2.4_rc5 ]
 * 71 out of 71 files good

tools-portage team: Tempted to resolve as WORKSFORME, but you may want to see this or have advice?
Comment 3 Alexey Parshin 2008-07-24 02:55:33 UTC
All I'm saying that under certain conditions the messages displayed don't reflect the actual picture. I'd be glad to help you with diagnostics.
Comment 4 Alexey Parshin 2008-07-24 03:21:44 UTC
Created attachment 161234 [details]
Patch for equery to fix the bug

The attached file is the diff between the original equery and equery.my that works correctly. Since I'm not a python hacker I've made the least possible change.
Comment 5 Paul Varner (RETIRED) gentoo-dev 2008-07-24 16:07:09 UTC
Thanks, your patch is the correct fix. st.st_mtime is of type float, so we were comparing a float to an integer.

$ svn commit -m "Fix equery check to convert mtime to an integer so that comparisions always work." ChangeLog src/equery/equery
Sending        ChangeLog
Sending        src/equery/equery
Transmitting file data ..
Committed revision 502.
Comment 6 Paul Varner (RETIRED) gentoo-dev 2008-08-27 16:07:12 UTC
Released in gentoolkit-0.2.4_rc6