Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 230191 - app-editors/nano-2.1.2 doesn't need langinfo.h
Summary: app-editors/nano-2.1.2 doesn't need langinfo.h
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-30 14:37 UTC by Alan Hourihane
Modified: 2008-07-11 06:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
langinfo patch (nano-2.1.2-langinfo.patch,272 bytes, patch)
2008-07-09 07:28 UTC, Fabian Groffen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hourihane 2008-06-30 14:37:22 UTC
My system doesn't have langinfo.h and when compiling nano it fails at nano.c.

Removing the include to <langinfo.h> lets things compile.

Is there a need for <langinfo.h> ??

Reproducible: Always
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2008-06-30 14:56:48 UTC
emerge --info, please. langinfo.h is part of glibc.
Comment 2 Alan Hourihane 2008-06-30 15:02:19 UTC
I'm using prefix (Gentoo/Alt) so I don't use glibc.

But regardless of that, it seems to be a useless include.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-06-30 16:06:02 UTC
(In reply to comment #2)
> I'm using prefix (Gentoo/Alt) so I don't use glibc.
> 
> But regardless of that, it seems to be a useless include.
> 

We copy what upstream does. If SpanKY deems this WONTFIX then we will patch it for Gentoo Prefix use..
Comment 4 SpanKY gentoo-dev 2008-06-30 17:10:02 UTC
your system is broken ... nano does use it and the header is required by POSIX:
http://www.opengroup.org/onlinepubs/009695399/functions/nl_langinfo.html
http://www.opengroup.org/onlinepubs/009695399/basedefs/langinfo.h.html

i can probably get upstream to change it so the include only happens when ENABLE_UTF8 is defined, but if you want to use USE=unicode on a system which is not POSIX compliant, that's your problem
Comment 5 Alan Hourihane 2008-06-30 17:24:03 UTC
I don't use USE=unicode, so it seems adding ENABLE_UTF8 is the right approach.
Comment 6 Fabian Groffen gentoo-dev 2008-07-09 07:28:49 UTC
Created attachment 159939 [details, diff]
langinfo patch

How about this patch, does it resolve the issue?  At least it doesn't break for me.
Comment 7 Alan Hourihane 2008-07-09 07:36:47 UTC
Yes, that's exactly what vapier suggested in comment #4
Comment 8 Fabian Groffen gentoo-dev 2008-07-09 07:39:15 UTC
good.  SpanKY, do you want to apply it in gentoo-x86, or shall I just keep it in Prefix?
Comment 9 Alan Hourihane 2008-07-10 23:28:45 UTC
I guess adding it to prefix would be good for now.
Comment 10 Fabian Groffen gentoo-dev 2008-07-11 06:39:38 UTC
Ok, added, also filed a "patch" for it
https://savannah.gnu.org/patch/index.php?6565

I guess that fixes the issue for us.