Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 227225 - repoman should not allow using the ~ operator with an explicit revision
Summary: repoman should not allow using the ~ operator with an explicit revision
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 196561 288499
  Show dependency tree
 
Reported: 2008-06-15 15:36 UTC by David Leverton
Modified: 2010-09-23 02:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-repoman-warning-for-useless-with-revision-usage.patch (0001-repoman-warning-for-useless-with-revision-usage.patch,1.90 KB, patch)
2009-10-17 23:38 UTC, David Leverton
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Leverton 2008-06-15 15:36:33 UTC
As bug 196561 notes, the description in PMS of the ~ operator differs from Portage behaviour when a revision part is specified: specifically, ~foo/bar-1-r1 matches all of foo/bar-1, foo/bar-1-r1 and foo/bar-1-r2 in Portage, but only the latter two in PMS.  In the past there has been at least one ebuild that appeared to expect the PMS behaviour, however there are none in the current tree.  repoman should disallow this usage, to prevent such confusion from happening in future, as it behaves the same as the equivalent with no revision part specified and therefore there is no sensible reason to use it.
Comment 1 Ulrich Müller gentoo-dev 2009-10-14 07:05:36 UTC
> As bug 196561 notes, the description in PMS of the ~ operator differs from
> Portage behaviour

It is not a problem of Portage or RepoMan if PMS is ignoring reality.
Comment 2 David Leverton 2009-10-14 17:26:54 UTC
(In reply to comment #1)
> > As bug 196561 notes, the description in PMS of the ~ operator differs from
> > Portage behaviour
> 
> It is not a problem of Portage or RepoMan if PMS is ignoring reality.
> 

The bug report contains a full explanation of why this enhancement is desired.  Feel free to discuss if you disagree.
Comment 3 David Leverton 2009-10-17 23:38:46 UTC
Created attachment 207441 [details, diff]
0001-repoman-warning-for-useless-with-revision-usage.patch

This seems to do it....
Comment 4 Zac Medico gentoo-dev 2009-10-18 00:23:39 UTC
(In reply to comment #3)
> Created an attachment (id=207441) [details]
> 0001-repoman-warning-for-useless-with-revision-usage.patch

Thanks, this is in svn r14629.
Comment 5 Zac Medico gentoo-dev 2009-10-31 04:34:27 UTC
This is fixed in 2.1.7.2 and 2.2_rc47.