226855 – x11-themes/gtk-engines-industrial: patch (gtk-engines-industrial-0.2.36-gtk1_only.patch) changes both autotools source and result

Bug 226855 - x11-themes/gtk-engines-industrial: patch (gtk-engines-industrial-0.2.36-gtk1_only.patch) changes both autotools source and result

Summary: x11-themes/gtk-engines-industrial: patch (gtk-engines-industrial-0.2.36-gtk1_...

Status:	RESOLVED INVALID

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	bad-autotools
	Show dependency tree

Reported:	2008-06-14 17:50 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2008-10-28 23:48 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-14 17:50:07 UTC

The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.

Comment 1 Rémi Cardona (RETIRED) gentoo-dev

2008-10-28 23:48:52 UTC

False positive. Only Makefile.am and configure.ac are touched by this patch. Closing