First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 224917
Alias:
Product:
Component:
Status: NEW
Resolution:
Assigned To: Gentoo Quality Assistance Team <qa@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Diego E. 'Flameeyes' Pettenò <flameeyes@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 224917 depends on: Show dependency tree
Bug 224917 blocks: 226305
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.








View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-06-04 17:50 0000 
The ESVN_BOOTSTRAP and EGIT_BOOTSTRAP variables seems to be used only to call
boostrap/autogen scripts (instead of using eautoreconf).

Considering that boostrap/autogen scripts are usually a very nasty idea, I'd
like for use of the two variable to raise a QA Warning.

If further steps are needed after the source fetching through subversion/git,
it should happen in src_unpack as we do for every other thing in other ebuilds
and eclasses.

(Similarly, ESVN_PATCHES and EGIT_PATCHES should be deprecated too, if we
really want to make that change, we could just let subversion and git eclasses
inherit base.eclass and use the already-present PATCHES array, instead of
reinventing the wheel).

------- Comment #1 From Ciaran McCreesh 2008-06-04 18:04:46 0000 ------- 
You're assuming that bootstrap scripts can be replaced by calling eautoreconf.
This often isn't the case.

------- Comment #2 From Diego E. 'Flameeyes' Pettenò 2008-06-04 18:08:43 0000 ------- 
No I'm not.

> If further steps are needed after the source fetching through subversion/git,
> it should happen in src_unpack as we do for every other thing in other ebuilds
> and eclasses.

------- Comment #3 From Ciaran McCreesh 2008-06-04 18:10:15 0000 ------- 
Sure. And that thing is often "run the autogen / bootstrap" script. So you
might as well just use the *_BOOTSTRAP var.
First Last Prev Next    No search results available      Search page      Enter new bug