Bug 224381 – kde-base/kdemultimedia-3.5.9: Fix compiler warnings to get it compiled with FEATURES="strict"

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Hüwe 2008-05-31 17:28:15 UTC]

* QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * plat_linux_cdda.c:142: warning: implicit declaration of function 'free'

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.kde.org/
 *
 * ERROR: kde-base/kdemultimedia-3.5.9 failed.
 * Call stack:
 *       misc-functions.sh, line 609:  Called install_qa_check
 *       misc-functions.sh, line 324:  Called die
 * The specific snippet of code:
 *              [[ ${abort} == "yes" ]] && hasq stricter ${FEATURES} && die "poor code kills airplanes"
 *  The die message:
 *   poor code kills airplanes


Reproducible: Always

Steps to Reproduce:
1. FEATURES="strict stricter" emerge =kde-base/kdemultimedia-3.5.9
Actual Results:  
Emerge failes with  
*  The die message:
*   poor code kills airplanes

Expected Results:  
Kdemultimedia should install

Fix it with simple add of an #include <stdlib.h> line to kdemultimedia-3.5.9/kscd/libwm/plat_linux_cdda.c
-> See patch.

[Comment 1 Peter Hüwe 2008-05-31 17:29:08 UTC]

Created attachment 154975 [details, diff]
This is a patch that adds the needed include statements

[Comment 2 Peter Hüwe 2008-05-31 17:29:38 UTC]

Created attachment 154977 [details]
Updated Ebuild which includes the patch,

[Comment 3 Carsten Lohrke (RETIRED) 2008-08-29 01:02:05 UTC]

Thanks for your patch, Peter. Will be part of KDE 3.5.10.

[Comment 4 Carsten Lohrke (RETIRED) 2008-09-14 23:22:21 UTC]

3.5.10 is in testing, now.