Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 224277 - sys-apps/hal-0.5.11-r1 fails to install some .fdi files and migrate-xorg-to-fdi.py [patch]
Summary: sys-apps/hal-0.5.11-r1 fails to install some .fdi files and migrate-xorg-to-f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Saleem Abdulrasool (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 224279
  Show dependency tree
 
Reported: 2008-05-30 23:01 UTC by Colin Macdonald
Modified: 2008-09-04 22:32 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Xuseflag-fixes.patch (Xuseflag-fixes.patch,947 bytes, patch)
2008-05-30 23:03 UTC, Colin Macdonald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Macdonald 2008-05-30 23:01:52 UTC
dodoc: /var/tmp/portage/sys-apps/hal-0.5.11-r1/work/hal-0.5.11-extras/*.fdi does not exist
!!! dobin: /var/tmp/portage/sys-apps/hal-0.5.11-r1/work/hal-0.5.11-extras/migrate-xorg-to-fdi.py does not exist
 * Migrating xorg.conf Core Keyboard configuration to HAL FDI file...
>>> Completed installing hal-0.5.11-r1 into /var/tmp/portage/sys-apps/hal-0.5.11-r1/image/

In:
/var/tmp/portage/sys-apps/hal-0.5.11-r1/work
there is no hal-0.5.11-extras directory.

total 20
drwx------  5 portage portage 4096 May 30 15:38 .
drwxrwxr-x  6 portage portage 4096 May 30 15:38 ..
drwxr-xr-x 12 portage portage 4096 May 30 15:38 hal-0.5.11
drwxr-xr-x  2 portage portage 4096 May 25 15:39 hal-0.5.11-patches
drwxr-xr-x  2 portage portage 4096 May 22 10:53 hal-config-examples

Will attach patch to use hal-config-examples/ instead.



There may be another issue here:

		# Automagic conversion!
		elog "Migrating xorg.conf Core Keyboard configuration to HAL FDI file..."
		"${WORKDIR}/${P}-extras/migrate-xorg-to-fdi.py" 2> /dev/null > "${D}/etc/hal/fdi/policy/10-x11-input.fdi"

Directing stderr to /dev/null strikes me as a bad idea.  Maybe there should be some logic to check if this fails (e.g., if migrate-xorg-to-fdi.py doesn't exist).  I haven't looked into that.
Comment 1 Colin Macdonald 2008-05-30 23:03:06 UTC
Created attachment 154889 [details, diff]
Xuseflag-fixes.patch

This doesn't try to do anything about the migrate-xorg-to-fdi.py issue raised above, just the low-hanging fruit (wrong paths)
Comment 2 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2008-06-27 10:59:18 UTC
(In reply to comment #0)
> Directing stderr to /dev/null strikes me as a bad idea.  Maybe there should be
> some logic to check if this fails (e.g., if migrate-xorg-to-fdi.py doesn't
> exist).  I haven't looked into that.

Appending || die "xorg migration failed" at the end should be fine.
Comment 3 Saleem Abdulrasool (RETIRED) gentoo-dev 2008-09-04 22:32:29 UTC
Fixed with -r2.  The redirection is to prevent garbage from being written to the file.  There is a warning now if the conversion fails.