Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223171 - Scratchy sound in pygame-1.8.0 due to buffer size miscalculation.
Summary: Scratchy sound in pygame-1.8.0 due to buffer size miscalculation.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-22 07:51 UTC by Charlie Nolan
Modified: 2008-09-26 15:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild to incorporate patch. (pygame-1.8.0-r1.ebuild,1.40 KB, text/plain)
2008-05-22 07:54 UTC, Charlie Nolan
Details
Patch to fix problem. (pygame_sound_patch.patch,609 bytes, patch)
2008-05-22 07:54 UTC, Charlie Nolan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Nolan 2008-05-22 07:51:43 UTC
pygame-1.8.0 is giving scratchy sound due to a miscalculation of buffer size.  It's intended to increase the buffer size to the next power of two, but instead sets it to 256, regardless of the input.

Upstream has fixed it in SVN here:
http://www.seul.org/viewcvs/viewcvs.cgi/trunk/src/mixer.c?root=PyGame&rev=1222&r1=1158&r2=1222

My patch is slightly different, but has the same basic effect.  I'll be sending it upstream shortly, as it is more readable than the official version.

Reproducible: Always
Comment 1 Charlie Nolan 2008-05-22 07:54:07 UTC
Created attachment 153907 [details]
Ebuild to incorporate patch.
Comment 2 Charlie Nolan 2008-05-22 07:54:30 UTC
Created attachment 153909 [details, diff]
Patch to fix problem.
Comment 3 Robert Buchholz (RETIRED) gentoo-dev 2008-09-26 15:01:54 UTC
The patch you referenced is in 1.8.1, and that has the same keywords as 1.8.0 in the tree.

Closing this bug, please reopen if you disagree.