Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 220761 - revdep-rebuild: Speedup by not assigning the same file several times
Summary: revdep-rebuild: Speedup by not assigning the same file several times
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 170220
  Show dependency tree
 
Reported: 2008-05-07 14:21 UTC by Hanno Böck
Modified: 2008-07-10 16:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
speedup revdep-rebuild by doing sort|uniq between step 3 and 4 (revdep-rebuild-speedup.diff,677 bytes, patch)
2008-05-07 14:22 UTC, Hanno Böck
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2008-05-07 14:21:32 UTC
If several breakages occur on one file (e.g. on .la files), revdep-rebuild wants to assign it to a package several times, which heavily slows it down. Looks like this:

 * Assigning files to packages
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
[...]

Between step 3 and 4, one could just insert a sort|uniq to avoid this. I've written a fast and ugly patch for it.
Comment 1 Hanno Böck gentoo-dev 2008-05-07 14:22:06 UTC
Created attachment 152281 [details, diff]
speedup revdep-rebuild by doing sort|uniq between step 3 and 4
Comment 2 Paul Varner (RETIRED) gentoo-dev 2008-07-09 19:01:24 UTC
$ svn commit -m "Fix revdep-rebuild to not evaluate broken objects multiple times. (Bug 220761)" ChangeLog src/revdep-rebuild/revdep-rebuild
Sending        ChangeLog
Sending        src/revdep-rebuild/revdep-rebuild
Transmitting file data ..
Committed revision 493.
Comment 3 Paul Varner (RETIRED) gentoo-dev 2008-07-10 16:47:41 UTC
Released in gentoolkit-0.2.4_rc5.