Bugzilla Bug 214489

dev-python/pygame depends on media-libs/libsdl which can be built with USE="-X"
(think of DirectFB for example). It would be nice (and Gentoo-ish) if upcoming
dev-python/pygame ebuilds would not be telling me I should emerge libsdl with
USE="X", when I'm explicitly running an X-less multimedia system (a HTPC
outputting video via DirectFB), on which I occasionally use Freevo? I'm use any
game emulator in Freevo itself, it's juat that pygame is still a required
dependency.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
emerging dev-python/pygame-1.8.0_rc4.ebuild mocks about libsdl not having been
emerged with USE="X".

Expected Results:  
the pygame ebuild should play nice and respect the user'S _choice_ about USE
flags (epecially since it's technically possible).

  03 Mar 2008; Tiziano Müller <dev-zero@gentoo.org>
  pygame-1.8.0_rc4.ebuild:
  Fixed various QA issues. Added check that libSDL is compiled with X support
  (bug #150329). And it now supports unicode (bug #154012 is therefore solved
  as well).

Sorry that I entered the text of my bug report too fast, maybe I wasn't too
explicit. How come that this is not a bug, forcing such a huge dependency like
"X" when it's not necessary?

What's not necessary? Read bug #150329 perhaps?

I read that. Did you read this comment, too
http://bugs.gentoo.org/show_bug.cgi?id=150329#c4 ?
In the spirit of Gentoo (having CHOICE), the solution should be a combination
of that proposed in this comment, and your solution (forcing X).
Plain and simple as letting the pygame ebuild have a USE flag "X", and enforce
having the dependency libsdl beeing compiled with "X", ONLY if the flag is set
for pygame, too, else, just compile without X11 support like proposed in the
linke I gave.

Created an attachment (id=147157) [details]
disable X11 source patch

May not be teh most elegant place to disable it, but looked pretty effective to
me since DISABLE_X11 is checked in 3 places in pygame's source code.

Created an attachment (id=147158) [details]
disable X11 ebuild patch

You might at least have a look at the attached patches, whioch OPTIONALLY
disable X11 (by the "X" USE flag).

*** This bug has been marked as a duplicate of bug 150329 ***

Er... regardless of whether this is a duplicate, either this bug or #150329
should be reopened for the pygame maintainers to look at the attached patch.
It's probably easiest to keep it here.

CC'ed René Dudfield, part of upstream or something like that ;-).

René, maybe you can give us some advice about this problem...?

(In reply to comment #10)
> CC'ed René Dudfield, part of upstream or something like that ;-).
> 
> René, maybe you can give us some advice about this problem...?
> 

Hi,

yeah, pygame can be used without X (if it can't it's a bug we need to fix).

I'm not sure how the rest of SDL programs deal with this in gentoo?  However I
think that's probably the best method to follow.

cheers,

Defining DISABLE_X11 causes compilation failure in dev-python/pygame-1.8.1-r1:

src/scrap.c:74:6: error: #error Unknown window manager for clipboard handling

(In reply to comment #12)
> Defining DISABLE_X11 causes compilation failure in dev-python/pygame-1.8.1-r1:
> 
> src/scrap.c:74:6: error: #error Unknown window manager for clipboard handling
> 

Well, it does not cause any compilation failure if the config script does not
find any "SCRAP" (I do not know what that is and also don't even mind what it
is since I only want to get pygame built as a dependency on my HTPC system to
run Freevo with DirectFB output via SDL, and actually don't care of games) on
the system.
Have a look here:
http://www.mail-archive.com/pygame-users@seul.org/msg11907.html René Dudfield
says it might be only this SCRAP thing really requiring X11 stuff. But, on the
other side, why isn't there any such SCRAP found on my X11-less setup? I also
cannot find an ebuild in the portage tree containing it, maybe it's called
different.
So, as expected, pygame can optionally be used without X (if one choses to miss
the marvelous X11 features), even if gentoo ebuild maintainers seem not to be
willing to accept this...

Reopen with a working patch.

Created an attachment (id=192934) [details]
X11 optional entirely depending on X USE flag

Well, the patch working for me is the same I submitted 14 months ago for
version 1.8.0_rc4 which you just obsoleted, the same applies currently for
1.8.1-r1. The patch to the current ebuild also does the same as the old ebuild
patch did, I'm submitting an updated one for the ebuild, the sources patch is
not changed.

However, given the SCRAP module thing I told you about, I could only test on my
desktop machine, where the X USE flag is set and SCRAP is found (don't know
from which ebuild):

Hunting dependencies...
SDL     : found 1.2.13
FONT    : found
IMAGE   : found
MIXER   : found
SMPEG   : found 0.4.4
PNG     : found
JPEG    : found
SCRAP   : found

On my machine without X, and with the patch, only SCRAP is not found and pygame
builds successfully. Hope this helps, finally...

(From update of attachment 147157 [details])
still applies to 1.8.1-r1

reopening as requested

DISABLE_X11 seems to not be supported in dev-python/pygame-1.9.1.