Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 212621 - Add more variables to ebuild.minorsyn's quoting check for games.eclass
Summary: Add more variables to ebuild.minorsyn's quoting check for games.eclass
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 216231
  Show dependency tree
 
Reported: 2008-03-07 20:44 UTC by Chris Gianelloni (RETIRED)
Modified: 2008-04-04 22:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
repoman-gamesvars.diff (repoman-gamesvars.diff,1.46 KB, patch)
2008-03-07 20:44 UTC, Chris Gianelloni (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gianelloni (RETIRED) gentoo-dev 2008-03-07 20:44:12 UTC 
There are many user-definable variables in games.eclass which allows a user to customize how games are installed on Gentoo.  Since they're user-definable, they could have spaces in them.

Also, there's two commonly-used variables in games, "dir" and "Ddir", which we use to tell portage where to install things.  These invariably pull in one of the GAMES_* variables, so they need to be quoted, also.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2008-03-07 20:44:52 UTC 
Created attachment 145502 [details, diff]
repoman-gamesvars.diff

This patch adds support for the GAMES_* variables and dir/Ddir...
Comment 2 Zac Medico gentoo-dev 2008-03-19 10:55:38 UTC 
Should we just make it match GAMES_* or is it better if we list each one explicitly?
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2008-03-25 22:24:11 UTC 
Well, only those are user-definable at this time.  There are others that aren't user-definable, and don't require quoting.  It wouldn't *hurt* to check them all, though.
Comment 4 Zac Medico gentoo-dev 2008-04-04 22:23:43 UTC 
This is fixed in 2.1.5_rc1.