Bugzilla Bug 210415

The audacity ebuild should include a reference to the
jack-audio-connection-kit, either via a USE flag or in RDEPENDS.

Audacity 1.3.4-r1 compiles fine with the lowest version of Jack available on my
AMD64 machine (version 0.103.0), but my machine had an older version of Jack
installed (it was still at an 0.9x version).  Since it wasn't included in the
audacity deps, it caused audacity compilation to fail.  It's an easy feature to
add, but isn't obvious to the user why the emerge fails without investigating
the output of ./configure; I wasn't aware that Audacity depended on Jack until
looking through the ./configure and make output.

Reproducible: Always

Steps to Reproduce:
1. Have an old version of jack-audio-connection-kit installed (pre-0.103.0)
2. Emerge audacity
3. Audacity fails to install

dep added, thanks

Why has the dependency been added without a USE flag?
I've had Audacity working fine without jack installed, and now my system wants
to pull it in.

(In reply to comment #2)
> Why has the dependency been added without a USE flag?
> I've had Audacity working fine without jack installed, and now my system wants
> to pull it in.
> 

because upstream provides no reliable way to disable it ? and then it would
result in different binaries even if built with the exact same options whether
jack was installed at build time or not. And that wouldnt solve the initial
problem if adding only an useflag: USE=-jack and have an old jack installed and
that'll fail...

So add a configure option? That dependency doesn't solve the initial problem
either.

(In reply to comment #4)
> So add a configure option? 

patches sent upstream too are very welcome

> That dependency doesn't solve the initial problem
> either.

why that ?

Wouldn't it be possible to just print a message at pkg_unpack stage and/or
detect if the installed jackd is in an incompatible version and die? It's
completely anoying to install bloat like jackd just for audacity, i'm not
needing it at all, it's waste of resources and maintenance time.

(In reply to comment #1)
> dep added, thanks
> 

Why?  I have never had jack on my systems over the years and have zero
intention of installing it just to use audacity.  Things were 100% fine until
this "update".  Now I can't simply "emerge world" because jack will be
installed, in-turn mess up other sound apps by seeing some kind of jack
installed, and I now can't use --depclean anymore since the jack dependency
makes it fail.  
If the jack use flag is there, then a system is going to have a full jack
install for all the other apps needing it, right (I'm asking an honest
question)?  
Could the possibility exist that the OP's world file is messed up and portage
isn't seeing it installed and thus not updating it?  Perhaps he/she installed
it with a --oneshot or (if it's REALLY old) --inject?

(I'm asking honest questions, I'm not trying to flame anyone of come off as
"pissed-off".  I'm only pretty annoyed that I have to sit in front of my
machines babysitting them every single time I want to update my machine to make
sure that jack isn't installed / continuing a portage fail because of it)  

(In reply to comment #7)
> Why?  I have never had jack on my systems over the years and have zero
> intention of installing it just to use audacity.  Things were 100% fine until
> this "update".  Now I can't simply "emerge world" because jack will be
> installed, in-turn mess up other sound apps by seeing some kind of jack
> installed, and I now can't use --depclean anymore since the jack dependency
> makes it fail.  

I agree with this as well, I never needed jack to run audacity, so don't think
it should be a dependency now.

The audacity wiki also states that audacity using jack has not been extensively
tested and has a number of issues:

   http://www.audacityteam.org/wiki/index.php?title=Linux_Issues#JACK

It also mentions that audacity-with-jack should be enabled by using portaudio
with both jack and alsa enabled. How about adding jack and alsa USE keywords to
portaudio (and requiring portaudio to use the minimum version of jack that
audacity requires)? Then audacity could use a portaudio USE keyword to enable
jack support?

(As it is, "emerge world" is trying to pull in jack, but audacity is even going
to get rebuilt to use the new jack headers..)

(In reply to comment #2)
> Why has the dependency been added without a USE flag?
> I've had Audacity working fine without jack installed, and now my system wants
> to pull it in.
> 

I agree, a USE flag for jack-audio-connection-kit is needed. Why should I have
Jack forced upon me when Audacity works perfectly well without it?

*** Bug 211183 has been marked as a duplicate of this bug. ***

*** Bug 211212 has been marked as a duplicate of this bug. ***

Created an attachment (id=144482) [details]
audacity-1.3.4-jack-automagic.patch

Patch to fix automagic jack-audio-connection-kit dependency.

Created an attachment (id=144483) [details]
audacity-1.3.4-r1.ebuild.diff

Fixed ebuild...

Reopen this bug, rest the above patch please.

Created an attachment (id=144485) [details]
audacity-1.3.4-r1.ebuild.diff

Errr, we'd better run eautoreconf as well... ;)

Ugh, this thing just sucks... Same fix needed in 

lib-src/portaudio-v19/configure.in
lib-src/portaudio-v19/bindings/cpp/build/gnu/configure.ac

plus WTH does this bundle its own portaudio (also see Bug 209494).

And more... 

- automagic dependency on media-libs/alsa-lib
- instead of using media-libs/allegro this links a static bundled copy in,
great :S
- this supports wxGTK-2.8 but we are forcing 2.6, why?

Thank you for working on this Jakub.  

Do you have the power to make these edits the the live ebuild?  I just set
myself up an overlay making jack optional so I can make portage shut up so I
can actually emerge world again (and use depclean).

Anyway, thank you for your work!

M.

should be fixed in -r2

(In reply to comment #19)
> should be fixed in -r2
> 

Fantastic!  Thank you!

(P.S. I didn't mean to make it seem I was stepping your toes.  I was only
asking Jakub a question, not try and go over your head.  I HOPE you understand
that)

(In reply to comment #20)

> (P.S. I didn't mean to make it seem I was stepping your toes.  I was only
> asking Jakub a question, not try and go over your head.  I HOPE you understand
> that)

Heh no problem I didn't see it like that ;)
I was just completely busy with non gentoo stuff for a few weeks; now I'm
emptying the backlog :)

In `diff audacity-1.3.4-{r1,r2}.ebuild` I see following hunk:

@@ -74,7 +89,8 @@
                $(use_with twolame libtwolame) \
                $(use_with soundtouch) \
                $(use_with libsamplerate) \
-               || die
+               $(use_with alsa) \
+               $(use_with jack)

        emake || die
 }

Was not it a typo to remove `die` on econf failure from -r2 ?

(In reply to comment #22)

> Was not it a typo to remove `die` on econf failure from -r2 ?

Excuse me for flood, I've found out it was not.

econf() from /usr/lib/portage/bin/ebuild.sh `die's itself it something goes
wrong.

(In reply to comment #19)
> should be fixed in -r2
> 

Just thought I'd mention that -r2 works fine here.  x86-32, no jack.

Again, thanx for the update!