Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 209296 - baselayout-2 showing 'wrong' message for fsck.xfs
Summary: baselayout-2 showing 'wrong' message for fsck.xfs
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://oss.sgi.com/bugzilla/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-07 21:32 UTC by Markus Rothe (RETIRED)
Modified: 2008-04-11 18:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add the p option (fsck.xfs_add_p_option.patch,287 bytes, patch)
2008-04-09 19:39 UTC, Markus Rothe (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Rothe (RETIRED) gentoo-dev 2008-02-07 21:32:51 UTC
baselayout-2 shows a long two line buld message instead of just "XFS file system." while booting. This is a pure cosmetic 'bug'. It would be nice, if this could be fixed though.

If you look at the script you will see it tries to detect if was run from a user or automated.

Here's the script cause you might not want to install xfsprogs just to see this tiny script ;-)

$ cat `which fsck.xfs`
#!/bin/sh -f
#
# Copyright (c) 2006 Silicon Graphics, Inc.  All Rights Reserved.
#

AUTO=false
while getopts ":aA" c
do
	case $c in
	a|A)	AUTO=true;;
	esac
done
if $AUTO; then
	echo "$0: XFS file system."
else
	echo "If you wish to check the consistency of an XFS filesystem or"
	echo "repair a damaged filesystem, see xfs_check(8) and xfs_repair(8)."
fi
exit 0
Comment 1 Roy Marples 2008-02-07 23:32:06 UTC
So someone just needs to add the -p option as we're using that now instead of -a.
Comment 2 Markus Rothe (RETIRED) gentoo-dev 2008-04-09 19:39:18 UTC
Created attachment 149230 [details, diff]
add the p option

I'm not sure why I haven't visited this bug for that long..

this small patch adds the p option to fsck.xfs.

base-system: do you want to apply it to xfsprogs?
Comment 3 Doug Goldstein (RETIRED) gentoo-dev 2008-04-09 21:21:05 UTC
Markus,

Feel free to commit.
Comment 4 Roy Marples 2008-04-11 10:42:39 UTC
(In reply to comment #2)
> Created an attachment (id=149230) [edit]
> add the p option

Not sure why you are trapping A and P as they mean different things to a and p.
Should just trap a and p :)
Comment 5 Markus Rothe (RETIRED) gentoo-dev 2008-04-11 18:41:43 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > Created an attachment (id=149230) [edit]
> > add the p option
> 
> Not sure why you are trapping A and P as they mean different things to a and p.
> Should just trap a and p :)
> 

I'm not sure, too... Corrected that and opened an upstream bug report at [1].

I decided to not add this patch to portage for now. I'll add it if upstream decides to _not_ add it -- so this is just not yet another patch to maintain. ;-)

[1] http://oss.sgi.com/bugzilla/show_bug.cgi?id=780