Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 20776 - mhwaveeditor-1.2.1 (New Package)
Summary: mhwaveeditor-1.2.1 (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jon Portnoy (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-10 23:49 UTC by Karl Haines
Modified: 2003-05-12 15:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mhwaveeditor-1.2.1.ebuild (mhwaveedit-1.2.1.ebuild,977 bytes, text/plain)
2003-05-10 23:51 UTC, Karl Haines
Details
How would I change the ebuild (my-proposal.diff,1.33 KB, patch)
2003-05-11 06:58 UTC, Gregorio Guidi (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Haines 2003-05-10 23:49:21 UTC
mhWaveEditor is a wav (and a few other formats) editor. It can use GT2 or GTK1,
oss, sdl, libsndfile, and portsound.

http://www.mtek.chalmers.se/~hjormagn/mhwaveedit.html
Comment 1 Karl Haines 2003-05-10 23:51:04 UTC
Created attachment 11781 [details]
mhwaveeditor-1.2.1.ebuild
Comment 2 Jon Portnoy (RETIRED) gentoo-dev 2003-05-11 00:11:54 UTC
I should be able to get to this soon.
Comment 3 Gregorio Guidi (RETIRED) gentoo-dev 2003-05-11 06:58:14 UTC
Created attachment 11784 [details, diff]
How would I change the ebuild

Since you asked for feedback on gentoo-dev, here is how I would have written
the ebuild:

-# http://www.mtek.chalmers.se/~hjormagn/mhwaveedit-1.2.1.tar.gz
+# $Header: $

I think this line is needed to automatize insertion of headers (devs, correct
me if I'm wrong)

-P=${PN}-${PV/_/}
-S=${WORKDIR}/${P}

Unneeded

-DEPEND="virtual/x11
-	gtk2? ( >=x11-libs/gtk+-2.0.0 )
+DEPEND="gtk2? ( >=x11-libs/gtk+-2.0.0 )

virtual/x11 is already a dependancy of gtk+

-	( >=media-libs/libsdl-1.2.3 )
+	sdl? ( >=media-libs/libsdl-1.2.3 )

Important!!

+	use sdl || myconf="${myconf} --without-sdl"

Important!!

-	econf ${myconf} || die
+	econf ${myconf}

See `man 5 ebuild'

And a little note: if someone uses alsa (has -oss) and has -sdl in USE, will
not be able to play wavs, and I don't know how to avoid that...

Bye!
Comment 4 Jon Portnoy (RETIRED) gentoo-dev 2003-05-12 15:35:15 UTC
Commited, thanks!