Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 206343
Alias:
Product:
Component:
Status: RESOLVED
Resolution: WORKSFORME
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Devils-Hawk <dev@stuffit.at>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
smartmontools-gcc43.patch gcc-4.3.0 patch for smartmontools-5.37 patch Devils-Hawk 2008-01-17 15:15 0000 517 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 206343 depends on: Show dependency tree
Bug 206343 blocks: 198121
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2008-01-17 15:12 0000 
Redefining a #define is an hard error in C++ now (not in C because the
standards differ). gcc-4.3.0 tries to conform => smartmontools do not like
that.
Attached patch should fix the compile. I think it preserves behaviour but it
should be noted that 1 line above the fix, the old value of the define is used
than the redefinition happens and then the new value is used. I do not have any
clue how the preprocessor handles this but i assumed it uses the new value only
from the point of redefinition onwards.

Reproducible: Always

------- Comment #1 From Devils-Hawk 2008-01-17 15:15:31 0000 ------- 
Created an attachment (id=141142) [details]
gcc-4.3.0 patch for smartmontools-5.37

------- Comment #2 From Ryan Hill 2008-01-17 18:29:42 0000 ------- 
Current GCC svn reverts the change that made redefinitions errors.  See
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24924.  Any checkout after -r131530
(14 Jan 2008) will work.  Thanks for the patch though. :)
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug