Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 196621 - gnome-extra/yelp-2.20.0 compilation fails
Summary: gnome-extra/yelp-2.20.0 compilation fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-21 15:34 UTC by BedOS_Gui
Modified: 2008-02-03 20:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --log (gnome-extra:yelp-2.20.0:20071021-152656.log,60.64 KB, text/plain)
2007-10-21 15:34 UTC, BedOS_Gui
Details
emerge --info (emerge--info,8.81 KB, text/plain)
2007-10-21 15:34 UTC, BedOS_Gui
Details
C++-style commentary should be replaced with a plain-C-style commentary (yelp-2.20.0.patch,569 bytes, patch)
2007-12-04 19:38 UTC, uchum
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BedOS_Gui 2007-10-21 15:34:05 UTC
In file included from yelp-window.c:48:
yelp-debug.h:56:35: warning: ISO C does not permit named variadic macros
yelp-window.c: In function 'window_set_section_cursor':
yelp-window.c:1501: warning: ISO C forbids passing argument 6 of 'g_signal_handlers_block_matched' between function pointer and 'void *'
yelp-window.c:1532: warning: ISO C forbids passing argument 6 of 'g_signal_handlers_unblock_matched' between function pointer and 'void *'
yelp-window.c: In function 'window_do_load_html':
yelp-window.c:1589: warning: missing sentinel in function call
yelp-window.c: In function 'window_reload_cb':
yelp-window.c:2162: error: expected expression before '/' token
make[3]: *** [yelp-yelp-window.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from yelp-transform.c:40:
yelp-debug.h:56:35: warning: ISO C does not permit named variadic macros
yelp-transform.c:46: warning: type defaults to 'int' in declaration of 'exslt_registered'
yelp-transform.c: In function 'xslt_yelp_document':
yelp-transform.c:410: warning: pointer targets in passing argument 1 of 'g_strdup' differ in signedness
make[3]: Leaving directory `/var/tmp/portage/gnome-extra/yelp-2.20.0/work/yelp-2.20.0/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/gnome-extra/yelp-2.20.0/work/yelp-2.20.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gnome-extra/yelp-2.20.0/work/yelp-2.20.0'
make: *** [all] Error 2
 * 
 * ERROR: gnome-extra/yelp-2.20.0 failed.

Reproducible: Always
Comment 1 BedOS_Gui 2007-10-21 15:34:34 UTC
Created attachment 134043 [details]
emerge --log
Comment 2 BedOS_Gui 2007-10-21 15:34:48 UTC
Created attachment 134045 [details]
emerge --info
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-10-21 16:50:58 UTC
gnome upstream and gnome herd doesn't support optimization level above 2 (-Os and -O3). Please try again with safer CFLAGS (-O2 -march=native -pipe)
Comment 4 BedOS_Gui 2007-10-21 18:06:51 UTC
(In reply to comment #3)
> gnome upstream and gnome herd doesn't support optimization level above 2 (-Os
> and -O3). Please try again with safer CFLAGS (-O2 -march=native -pipe)
> 
Same result with cflags :
CFLAGS="-march=native -mtune=native -O2 -pipe"
CXXFLAGS="${CFLAGS}"
Comment 5 BedOS_Gui 2007-10-21 18:14:22 UTC
(In reply to comment #3)
> gnome upstream and gnome herd doesn't support optimization level above 2 (-Os
> and -O3). Please try again with safer CFLAGS (-O2 -march=native -pipe)
> 
Same result with cflags :
CFLAGS="-march=native -mtune=native -O2 -pipe"
CXXFLAGS="${CFLAGS}"
Comment 6 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-22 15:31:43 UTC
re-emerge it without the debug use flag.  That sets -pedantic -ansi, which causes the build to fail on the (otherwise perfectly valid) C++ style comment at that line.
Comment 7 BedOS_Gui 2007-10-22 22:13:30 UTC
(In reply to comment #6)
> re-emerge it without the debug use flag.  That sets -pedantic -ansi, which
> causes the build to fail on the (otherwise perfectly valid) C++ style comment
> at that line.
> 
Many thanks for your explanation Daniel, yelp compiles fine with "-debug" USE flag, but is this an error's workaround before fixing such a bug or a definitive solution to this compilation problem ?
Comment 8 Rémi Cardona (RETIRED) gentoo-dev 2007-10-22 22:41:13 UTC
CFLAGS such as -pedantic or -Werror should _never_ be included in official release tarballs. It's just plain dumb. You can't predict what compilers your users are going to use 2 weeks or 6 months from when the tarball is released.

We try as much as we can to convince upstream devs to remove such flags, most of them understand. I guess we'll have to file a bug upstream about this.

Thanks
Comment 9 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-24 17:54:27 UTC
More importantly, the debug use flag probably doesn't do what you think it does.  We need to remove it from almost all gnome packages; currently, it's in the eclass, and breaks all kinds of things.

Here's the description of the debug use flag:

debug - Enable extra debug codepaths, like asserts and extra output. If you want to get meaningful backtraces see http://www.gentoo.org/proj/en/qa/backtraces.xml
Comment 10 Christopher Friedt 2007-11-03 08:26:35 UTC
Ah, I'm glad that somebody found a solution to this. I thought I would need to 
submit a patch to gnome ;-) 

Given that the package is marked ~x86 (as of a few days ago anyway) it's not 
so bad that it won't compile with +debug.

Thanks for pointing out a work-around.
Comment 11 uchum 2007-12-04 19:38:28 UTC
Created attachment 137728 [details, diff]
C++-style  commentary should be replaced with a plain-C-style commentary
Comment 12 Alexander Gabert (RETIRED) gentoo-dev 2007-12-29 17:35:14 UTC
thanks for the bug report, doing what the bug report describes fixed the compile failures for me also (had debug also in my use flags),


Alex
Comment 13 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-02-03 19:27:44 UTC
I've stripped off the silly flags, fix is in tree.
Comment 14 BedOS_Gui 2008-02-03 20:09:15 UTC
(In reply to comment #13)
> I've stripped off the silly flags, fix is in tree.
> 

The ebuild works fine thanks Gilles.