>>> Compiling source in /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41 ... * Preparing asus-laptop module Kernel configuration : CONFIG_BACKLIGHT_CLASS_DEVICE : [Y] CONFIG_LEDS_CLASS : [Y] make -C /usr/src/linux SUBDIRS=/var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver modules make[1]: Entering directory `/usr/src/linux-2.6.23-gentoo' CC [M] /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.o /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:210: warning: initialization from incompatible pointer type /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c: In function 'asus_hotk_notify': /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:734: error: implicit declaration of function 'acpi_bus_generate_event' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c: In function 'asus_led_exit': /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1083: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1083: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1084: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1084: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1085: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1085: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1086: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1086: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1087: error: 'struct led_classdev' has no member named 'class_dev' /var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.c:1087: error: 'struct led_classdev' has no member named 'class_dev' make[2]: *** [/var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver/asus-laptop.o] Error 1 make[1]: *** [_module_/var/tmp/portage/app-laptop/acpi4asus-0.41/work/acpi4asus-0.41/driver] Error 2 make[1]: Leaving directory `/usr/src/linux-2.6.23-gentoo' make: *** [default] Error 2 Reproducible: Always These problems may be solved with : -> from 2.6.23 Changelog ACPI: Schedule /proc/acpi/event for removal Schedule /proc/acpi/event for removal in 6 months. Re-name acpi_bus_generate_event() to acpi_bus_generate_proc_event() to make sure there is no confusion that it is for /proc/acpi/event only. Add CONFIG_ACPI_PROC_EVENT to allow removal of /proc/acpi/event. There is no functional change if CONFIG_ACPI_PROC_EVENT=y -> http://www.mail-archive.com/git-commits-head@vger.kernel.org/msg19616.html
Created attachment 133473 [details, diff] acpi4asus-0.41-2.6.23.patch
This doesn't work for me, after merging it I get the following: # modprobe asus-laptop FATAL: Error inserting asus_laptop (/lib/modules/2.6.23-gentoo-r1/acpi/asus-laptop.ko): No such device But previous version with kernel-2.6.22 works ok :-/
Created attachment 138902 [details] updated ebuild using patch above for easier usage creating new ebuild (In reply to comment #2) you should emerge this when you're on 2.6.23 kernel, this ussualy happens when you did that on prevous version of your kernel
Created attachment 139036 [details, diff] Better patch to fix the issue I fixed the issue before trying to search the bugs and prepared a patch on my own. :-\ My patch seems better anyway. I fixed the missing 'class_dev' as suggested in http://lkml.org/lkml/2007/7/23/151 Regards
Well this patch is not working for me, I tried it throught LKML suggestion when .23 was new and it compiles fine but fn keys didn't work :(
Maybe acpi4asus is no more longer needed. I am now using asus-latop module provided by kernel. You can find it in: Device Drivers ---> Misc devices ---> Asus Laptop Extras (EXPERIMENTAL) Its description is: CONFIG_ASUS_LAPTOP │ This is the new Linux driver for Asus laptops. It may also support some │ MEDION, JVC or VICTOR laptops. It makes all the extra buttons generate │ standard ACPI events that go through /proc/acpi/events. It also adds │ support for video output switching, LCD backlight control, Bluetooth and │ Wlan control, and most importantly, allows you to blink those fancy LEDs. │ │ For more information and a userspace daemon for handling the extra │ buttons see <http://acpi4asus.sf.net/>. │ │ If you have an ACPI-compatible ASUS laptop, say Y or M here.
Created attachment 140777 [details] "fixed" version of ebuild Ok I agree. This ebuild should be blocked for 2.6.23 kernels and above. Why to bother with it when we have complete functional mainstream resolution of all problems with this :)
Created attachment 140789 [details, diff] acpi4asus-0.41.ebuild.diff - do not compile the kernel module on 2.6.23+ kernels, and check for CONFIG_ASUS_LAPTOP instead - some cleanup (redundant dodir, einfo -> elog), quoting
Created attachment 140793 [details, diff] acpi4asus-0.41.ebuild.diff fix pkg_setup (can't use KV_DIR before it's set).
I have no CONFIG_ASUS_LAPTOP in my kernel (tuxonice-2.6.23-r6). There is only CONFIG_ACPI_ASUS.
(In reply to comment #10) > I have no CONFIG_ASUS_LAPTOP in my kernel (tuxonice-2.6.23-r6). There is only > CONFIG_ACPI_ASUS. > scarab@Ugly-Elf: /usr/src/linux > uname -a Linux Ugly-Elf 2.6.23-gentoo-r2 #24 Wed Jan 9 18:53:59 CET 2008 i686 Intel(R) Pentium(R) M processor 1.86GHz GenuineIntel GNU/Linux scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ASUS CONFIG_ASUS_LAPTOP=y scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ACPI_ASUS # CONFIG_ACPI_ASUS is not set I patch suspend2 myself rather than using that ebuild, cause it ussualy have some issues, but it should not remove other kernel options. Try to look into Device Drivers ---> Misc devices ---> Asus Laptop Extras (EXPERIMENTAL) if it's not there report bug (it'll be clearly bug of tuxonice-sources)
(In reply to comment #11) I also have no CONFIG_ASUS_LAPTOP in my kernel (Clean un-patched Gentoo-Sources-2.6.24-r8) I have been searching for hours for this option! > (In reply to comment #10) > > I have no CONFIG_ASUS_LAPTOP in my kernel (tuxonice-2.6.23-r6). There is only > > CONFIG_ACPI_ASUS. > > > scarab@Ugly-Elf: /usr/src/linux > uname -a > Linux Ugly-Elf 2.6.23-gentoo-r2 #24 Wed Jan 9 18:53:59 CET 2008 i686 Intel(R) > Pentium(R) M processor 1.86GHz GenuineIntel GNU/Linux > scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ASUS > CONFIG_ASUS_LAPTOP=y > scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ACPI_ASUS > # CONFIG_ACPI_ASUS is not set > > > I patch suspend2 myself rather than using that ebuild, cause it ussualy have > some issues, but it should not remove other kernel options. > > Try to look into > Device Drivers ---> > Misc devices ---> > Asus Laptop Extras (EXPERIMENTAL) > > if it's not there report bug (it'll be clearly bug of tuxonice-sources) > (In reply to comment #11) > (In reply to comment #10) > > I have no CONFIG_ASUS_LAPTOP in my kernel (tuxonice-2.6.23-r6). There is only > > CONFIG_ACPI_ASUS. > > > scarab@Ugly-Elf: /usr/src/linux > uname -a > Linux Ugly-Elf 2.6.23-gentoo-r2 #24 Wed Jan 9 18:53:59 CET 2008 i686 Intel(R) > Pentium(R) M processor 1.86GHz GenuineIntel GNU/Linux > scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ASUS > CONFIG_ASUS_LAPTOP=y > scarab@Ugly-Elf: /usr/src/linux > cat .config |grep CONFIG_ACPI_ASUS > # CONFIG_ACPI_ASUS is not set > > > I patch suspend2 myself rather than using that ebuild, cause it ussualy have > some issues, but it should not remove other kernel options. > > Try to look into > Device Drivers ---> > Misc devices ---> > Asus Laptop Extras (EXPERIMENTAL) > > if it's not there report bug (it'll be clearly bug of tuxonice-sources) >
Check out http://forums.gentoo.org/viewtopic-t-693153-highlight-configacpiasus.html If the option is not available, check that the dependencies are set : It was Device Drivers->LED Support->LED Class Support for me. Full Dependencies: MISC_DEVICES && X86 && ACPI && EXPERIMENTAL && !ACPI_ASUS && LEDS_CLASS && BACKLIGHT_CLASS_DEVICE
Created attachment 178123 [details, diff] Patch adding module USE flag This is a 0.41 ebuild patch that adds 'module' USE flag functionality to this ebuild. Kernel module is built only, if this USE flag is enabled. I don't know, how to put inherit statement into USE flag condition (it shows me illegal inherit error), so it's leaved there independent on USE flag setting.
Fix commited to the tree. (i really needed it working)
