Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 195536 - media-libs/libpng-1.2.21-r2 causes gnome-base/nautilus (and possibly other apps) to fail loading png's
Summary: media-libs/libpng-1.2.21-r2 causes gnome-base/nautilus (and possibly other ap...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-11 19:43 UTC by Pierre Poissinger
Modified: 2007-10-14 21:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
libpng: Correct the typo but no more (libpng-1.2.21-null-termination-v2.patch,541 bytes, patch)
2007-10-14 12:08 UTC, Pierre Poissinger
Details | Diff
version 1.2.22 seems to include "-r3" patch -> revert it to to just correct the typo but no more (correct-upstream.patch,1.03 KB, patch)
2007-10-14 17:26 UTC, Pierre Poissinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Poissinger 2007-10-11 19:43:29 UTC
using icon theme to OSX3.3 (http://nekohayo.googlepages.com/icons) results in a frozen nautilus, a gnome-theme-manager using 100% and unusable...

emerge info:
Portage 2.1.3.12 (default-linux/x86/2006.1, gcc-4.2.2, glibc-2.6.1-r0, 2.6.23-gentoo i686)
=================================================================
System uname: 2.6.23-gentoo i686 Intel(R) Core(TM)2 CPU T7200 @ 2.00GHz
Timestamp of tree: Thu, 11 Oct 2007 17:30:01 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.7, 2.1.1
dev-lang/python:     2.5.1-r2
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0_rc5
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LINGUAS="en fr zh_TW"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/layman/xeffects /usr/local/layman/gentopia /usr/local/layman/musicbrainz /usr/local/layman/sunrise"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acpi alsa amr apache2 artworkextra asf avahi bash-completion berkdb bitmap-fonts bluetooth bzip2 cairo cdda cddb cdio cdparanoia cdr cli cracklib crypt cups dbus dell divx divx4linux djvu dmi dri dts dv dvd dvdr dvdread emacs encode esd exif extrafilters ffmpeg firefox flac fortran gd gdbm ggi gif giff glitz gmedia gnome gnutls gpm gtk gzip-el hal howl iconv ieee1394 ipv6 isdnlog jack java jpeg jpeg2k lame libnotify live logrotate lzo matroska midi mmx mmx2 mmxext mng mod mozbranding mozdevelop mozilla mozsvg mp3 mp3rtp mp4 mpeg mplayer mudflap musepack ncurses nfs nls nptl nptlonly nsplugin objc ogg opengl openmp oss pam pcre pdf perl pic plugins png posix postgres postgress ppds pppd python quicktime rar readline real realmedia reflection rtc rtsp samba sdl session shout simplexml smp speex spell spl sse sse2 ssl ssse3 startup-notification stream subtitles svg swat tcpd tga theora threads tiff tracker truetype truetype-fonts type1-fonts unicode upnp v4l v4l2 vcd vidix vim vim-with-x vorbis vorbis-psy win32codecs wmf wmp x264 x86 xanim xcb xcomposite xft xine xinerama xml xmlreader xmlrpc xmlwriter xorg xosd xsl xulrunner xv xvid xvmc zip zlib" ALSA_CARDS="hda-intel usb-audio" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en fr zh_TW" USERLAND="GNU" VIDEO_CARDS="nvidia nv vesa"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


Reproducible: Always

Steps to Reproduce:
1. go to http://nekohayo.googlepages.com/icons
2. download icons theme 3.3 and install
3. enjoy a dead nautilus... .icons/.theme/.nautilus needs to be deleted to get back a workable env.

Actual Results:  
frozen nautilus

Expected Results:  
a nice wannabe mac desktop

This was working before but the update I made on the last week seems to have broke n something...
Comment 1 Rémi Cardona (RETIRED) gentoo-dev 2007-10-11 19:52:43 UTC
I suggest you open a bug in Gnome's bugzilla, you'll probably have more luck there :) Please add gnome@gentoo.org as a CC there.

Thanks
Comment 2 Pierre Poissinger 2007-10-11 21:35:58 UTC
Thx, will do that this weekend (and resolve this one to upstream when done...)

btw, I still hope to find the time to look further in this before going upstream...or i am sure that I will have to wait 2.22 to see a fix for that :-P )
Comment 3 Pierre Poissinger 2007-10-13 18:53:33 UTC
Ok, after recompile of 
# gnome-base/nautilus
# dev-libs/glib
# x11-libs/gtk+
# app-text/evince
# x11-themes/gnome-themes
# x11-themes/gnome-themes-extras
# x11-themes/gnome-icon-theme
# x11-themes/gtk-engines
# x11-libs/pango
# gnome-base/gnome-vfs
# gnome-base/control-center
# gnome-base/gnome-desktop
in debug, I was unable to reproduce the problem, then recompile everything back to normal, everything was still fine... 

I still have no clue of what exactly was broken and resulted in this problem ... but as long as it's working again :-)
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-10-13 23:41:48 UTC
did you by any chance update libpng in the meantime as well ?
Comment 5 Pierre Poissinger 2007-10-14 12:00:08 UTC
Bingo !
At time of the problem, I was running media-libs/libpng-1.2.21-r2
When problem was fixed, I used media-libs/libpng-1.2.21-r3

==> libpng was the guilty and needed the libpng-1.2.21-null-termination-v2.patch

Side note: Since I was curious, I took a look at the patch, and it's not 100% perfect: it actually fix an issue actually not linked to null term but to a wrong copy (obviously a typo) and contains a inefficient chunk.
[It's not really a issue, it's just FYI...] 

I will attach a 1 hunk patch that fix the problem
Comment 6 Pierre Poissinger 2007-10-14 12:08:38 UTC
Created attachment 133435 [details, diff]
libpng: Correct the typo but no more

Clean (and IMHO better) libpng patch
Btw, naming should be libpng-1.2.21-pngset-typo (since the bug is more a typo than a missing null term)
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-10-14 12:57:37 UTC
reopening to assign to base-system
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-10-14 12:59:59 UTC
hi base-system,

this bug was due to libpng 1.2.12-r2 which is now fixed but reporter has a potential better fix. Please review.
Comment 9 Pierre Poissinger 2007-10-14 17:26:21 UTC
Created attachment 133458 [details, diff]
version 1.2.22 seems to include "-r3" patch -> revert it to to just correct the typo but no more

Upstream took the -r3 patch, so I revert this change to avoid these 2 strlen
Comment 10 SpanKY gentoo-dev 2007-10-14 17:27:57 UTC
sounds like libpng-1.2.21-r3 and libpng-1.2.22 are fixed
Comment 11 Pierre Poissinger 2007-10-14 17:34:59 UTC
correct - but not really in the correct way :-p
Comment 12 SpanKY gentoo-dev 2007-10-14 21:28:24 UTC
if you think the libpng guys are doing something wrong, then send an e-mail here:
http://lists.sourceforge.net/mailman/listinfo/png-mng-implement
Comment 13 Pierre Poissinger 2007-10-14 21:51:22 UTC
Thanks, 
I already contacted the maintainer since they should know what they are doing... but from the answer I got, it's not (yet) a win win :-D .... 
[OTW]
One more reason to love Open Source: 2 lines of code = more hours of fun than playing Zelda (on a Wii) without arms...
[/OTW]