Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19425 - new openssh (3.6_p1) breaks KDE's sftp kioslave
Summary: new openssh (3.6_p1) breaks KDE's sftp kioslave
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Caleb Tennis (RETIRED)
URL:
Whiteboard:
Keywords:
: 20620 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-04-16 12:48 UTC by Max Kalika (RETIRED)
Modified: 2003-05-16 17:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes ssh breakage in 3.1.x (sftp.patch,1.45 KB, patch)
2003-05-12 11:12 UTC, Caleb Tennis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Kalika (RETIRED) gentoo-dev 2003-04-16 12:48:11 UTC
Since upgrading to new openssh-3.6_p1 I haven't been able to use KDE's sftp:// 
kioslave.  Today I really needed that functionality back so I downgraded openssh to 
3.5_p1-r1 and it all works all happily again.  I think I traced it down to the way kde 
starts up the ssh process -- the parameters no longer work the same for newer 
openssh.  It seems KDE starts ssh with parameters like 
 
  -o ForwardX11 no 
 
And the openssh folks changed to to require an "=" character -- i.e. 
 
  -o ForwardX11=no 
 
This is all very theoretical and uncertain -- just something I noticed based on the 
process list.  I know ps lies sometimes so the failure can be due to a completely 
different reason. 

Reproducible: Always
Steps to Reproduce:
 
Actual Results:  
hangs with the "connecting to host" window 

Expected Results:  
a new konqueror window with the contents of the remote host
Comment 1 Max Kalika (RETIRED) gentoo-dev 2003-04-16 12:49:17 UTC
forgot to mention:  using ~x86, and here's emerge --info 
 
Portage 2.0.47-r10 (default-x86-1.4, gcc-3.2.2, glibc-2.3.2-r1) 
================================================================= 
System uname: 2.4.20 i686 Pentium III (Coppermine) 
GENTOO_MIRRORS="ftp://ftp.ucsb.edu/pub/mirrors/linux/gentoo" 
CONFIG_PROTECT="/var/qmail/control /usr/kde/2/share/config 
/usr/kde/3/share/config /etc /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config 
/usr/share/config" 
CONFIG_PROTECT_MASK="/etc/gconf /usr/X11R6/lib/X11/xkb /etc/env.d" 
PORTDIR="/usr/portage" 
DISTDIR="/usr/portage/distfiles" 
PKGDIR="/usr/portage/packages" 
PORTAGE_TMPDIR="/var/tmp" 
PORTDIR_OVERLAY="/usr/local/portage" 
USE="x86 oss avi crypt cups encode gif jpeg libg++ libwww mpeg ncurses pdflib png 
quicktime spell truetype xml2 xv zlib berkdb readline arts tcltk java X sdl pam ssl 
python oggvorbis qt motif opengl cdr mmx pic sse alsa dvd ldap mozilla samba tiff 
-3dnow -apm -gdbm -gnome -gpm -gtk -imlib -kde -mikmod -nls -perl -slang -svga 
-tcpd -xmms" 
COMPILER="gcc3" 
CHOST="i686-pc-linux-gnu" 
CFLAGS="-mcpu=pentium3 -march=pentium3 -Os -pipe" 
CXXFLAGS="-mcpu=pentium3 -march=pentium3 -Os -pipe" 
ACCEPT_KEYWORDS="x86 ~x86" 
MAKEOPTS="-j8" 
AUTOCLEAN="yes" 
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage" 
FEATURES="sandbox ccache buildpkg distcc userpriv" 
Comment 2 Michele Balistreri (RETIRED) gentoo-dev 2003-05-08 10:01:19 UTC
*** Bug 20620 has been marked as a duplicate of this bug. ***
Comment 3 Caleb Tennis (RETIRED) gentoo-dev 2003-05-08 10:46:51 UTC
This has been noted as a bug on the kde bugzilla. 
 
http://bugs.kde.org/show_bug.cgi?id=51359 
 
We'll see where this goes.. 
Comment 4 Caleb Tennis (RETIRED) gentoo-dev 2003-05-12 10:00:47 UTC
The sftp ioslave code in KDE is not currently set up to be able to handle the change that have 
been made from openssh 3.5 to openssh 3.6.  I plan to create a patch for KDE, but it will be 
binary incompatible and as such it won't be available in the 3.1 branch.   
 
I recommend staying with 3.5 for now.  We are currently evaluating whether to require 
openssh 3.5 for kde 3.1, or to do some patching on the gentoo side. 
Comment 5 Caleb Tennis (RETIRED) gentoo-dev 2003-05-12 11:12:28 UTC
Created attachment 11825 [details, diff]
Fixes ssh breakage in 3.1.x
Comment 6 Caleb Tennis (RETIRED) gentoo-dev 2003-05-12 11:12:57 UTC
Scratch that, after some looking it looks like this may be an easier fix than I thought.  
  
I am attaching a patch against ksshprocess.cpp, which exists in the kdebase/kioslave/sftp/  
directory.  Can you try this patch out and see if it fixes your problem?  
Comment 7 Max Kalika (RETIRED) gentoo-dev 2003-05-12 11:57:11 UTC
compiling now.  will let you know in an hour or so.  thanks! 
Comment 8 Max Kalika (RETIRED) gentoo-dev 2003-05-12 13:01:55 UTC
there's a small error in the second hunk of the patch (missing + after tmp).  fixed it 
here locally, but still compiling. 
Comment 9 Max Kalika (RETIRED) gentoo-dev 2003-05-12 13:05:06 UTC
ok, just tried to use sftp with the new patch and now I get "Error encountered while 
talking to ssh."   It doesn't hang, but it also doesn't ask for login/password anymore. 
Comment 10 Caleb Tennis (RETIRED) gentoo-dev 2003-05-12 13:37:35 UTC
I don't have the kde source on this computer, so I can't run any more tests on the patch at 
the moment, but this is what you should see in the ps list after starting the sftp: 
 
/usr/bin/ssh -p 22 -o 'ForwardX11 no' -o 'ForwardAgent no' -e none -l caleb -v cvs.gentoo.org 
-s sftp 
 
Are you seeing something close to that? 
 
 
Comment 11 Max Kalika (RETIRED) gentoo-dev 2003-05-12 14:34:40 UTC
Unfortunately I can't run ps fast enough before the command finishes, and I can't for 
the life of me figure out how to use kdebugdialog so that it actually does anything 
useful.  Any hints would be greatly appreciated. 
Comment 12 Caleb Tennis (RETIRED) gentoo-dev 2003-05-12 15:33:08 UTC
Okay, after further investigation I was above to make this work. 
 
Please revert my first patch. 
 
Instead, in ksshprocess.cpp line 101 
 
"ssh-userauth2 successful:" 
 
change to: 
 
"Authentication succeeded" 
 
And try it.  It now works for me using openssh 3.6.  Upon your confirmation I'll make a patch 
for the gentoo ebuild. 
 
 
Comment 13 Max Kalika (RETIRED) gentoo-dev 2003-05-12 16:22:30 UTC
Confirmed!  Works all happily now with openssh 3.6.1_p1-r2.  Thank you for your help. 
Comment 14 Michele Balistreri (RETIRED) gentoo-dev 2003-05-16 17:18:24 UTC
caleb solved it, fix will be included in the next kde release (3.1.2)