Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 191914 - x11-wm/fvwm-2.5.21 ebuild: error in econf section
Summary: x11-wm/fvwm-2.5.21 ebuild: error in econf section
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop WM Team (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-09 22:22 UTC by srrijkers
Modified: 2008-05-04 08:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description srrijkers 2007-09-09 22:22:14 UTC 
The econf part of the fvwm-2.5.21 ebuild uses use_enable instead of use_with for enabling / disabling png support.

The ebuild (incorrectly) passes --enable-png-library, when it should pass --with-png-library instead (when the png USE-flag is set, of course). Since the configure script does not bail out on an invalid argument the enabling/disabling of png support becomes automagic: it all depends on whether libpng is found or not.

I currently don't know whether this affects other fvwm ebuilds as well, but I guess it does (unless fvwm changed their png configure parameters between versions 2.5.18 and 2.5.21).
Comment 1 srrijkers 2007-09-09 22:43:24 UTC 
Also, for the sake of avoiding issues with 'automagic' configuration, wouldn't it be proper form to include a `use_enable gtk` part as well?
Comment 2 srrijkers 2007-09-09 22:54:26 UTC 
Ignore the previous comment please; I'm stupid apparently. Sorry :).
Comment 3 David Shakaryan (RETIRED) gentoo-dev 2008-05-04 08:47:02 UTC 
This should be fixed in the ebuild for 2.5.25, which I just committed. Thanks. :)