Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 190438 - app-admin/conky-1.4.6 missing hwmon support.
Summary: app-admin/conky-1.4.6 missing hwmon support.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-27 18:15 UTC by Mike DeSimone
Modified: 2007-10-29 09:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that adds hwmon support. (conky-1.4.6-hwmon.patch,4.43 KB, patch)
2007-08-27 18:16 UTC, Mike DeSimone
Details | Diff
Patch to ebuild to pull in the patch. (conky-hwmon-ebuild.patch,378 bytes, patch)
2007-08-27 18:16 UTC, Mike DeSimone
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike DeSimone 2007-08-27 18:15:09 UTC
The conky devs promised hwmon support back last spring, and they have the patch, but they have yet to put it into the tarball, so it's not in the conky ebuild.

I will attach the patch and the diff for the ebuild.

Reproducible: Always

Steps to Reproduce:
1. Configure conky to display variables of the form ${hwmon 0 temp 0 input} (for example; any hwmon call will show this bug).
2. Watch conky print a message that it does not recognize the variable, and put {hwmon} in the display.
Comment 1 Mike DeSimone 2007-08-27 18:16:06 UTC
Created attachment 129350 [details, diff]
Patch that adds hwmon support.
Comment 2 Mike DeSimone 2007-08-27 18:16:37 UTC
Created attachment 129352 [details, diff]
Patch to ebuild to pull in the patch.
Comment 3 Mike DeSimone 2007-08-27 18:20:20 UTC
Corresponding bug report in conky dev tree (and where i got the patch):
http://sourceforge.net/tracker/index.php?func=detail&aid=1650894&group_id=143975&atid=757310
Comment 4 Brenden Matthews 2007-08-27 18:42:03 UTC
(In reply to comment #3)
> Corresponding bug report in conky dev tree (and where i got the patch):
> http://sourceforge.net/tracker/index.php?func=detail&aid=1650894&group_id=143975&atid=757310
> 

I'm not really sure what went wrong here, but either way its actually in conky now (as of rev 919 in svn).
Comment 5 Mike DeSimone 2007-08-28 00:45:23 UTC
Fair enough.  I was just pointing out that this is broken for me since I'm building from Portage, which uses the conky-1.4.6 tarball and not the latest svn.  I fixed it in my case by applying the patch in an overlay, and figure others might want to do the same.

Conky does not seem to have regular releases; it was 8 months or so between 1.4.5 and 1.4.6, and since 1.4.6 just came out, it might be even longer before this fix makes it into a released version.
Comment 6 Philip Kovacs 2007-08-31 04:05:56 UTC
I reworked the patch as submitted because the code to read i2c, platform and hwmon is essentially the same and there was some duplication of code there.

1.4.7 will offer i2c, platform and hwmon.
Comment 7 Philip Kovacs 2007-10-19 19:50:38 UTC
fixed for 1.4.7 and higher.  see bug 190839.
Comment 8 Daniel Black (RETIRED) gentoo-dev 2007-10-29 09:54:24 UTC
closing - 1.4.8 is in portage.